src/ic/handler-compiler.cc - Issue 1254623002: Remove ExternalArray, derived types, and element kinds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 1254623002: Remove ExternalArray, derived types, and element kinds (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index beeea32cc8ffa2a91a282cc50bf8081dda94ded6..eb2768c860ab81d924533c5c8515fbfb13d66597 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -568,7 +568,6 @@ void ElementHandlerCompiler::CompileElementHandlers(

} else if (IsSloppyArgumentsElements(elements_kind)) {

cached_stub = KeyedLoadSloppyArgumentsStub(isolate()).GetCode();

} else if (IsFastElementsKind(elements_kind) ||

- IsExternalArrayElementsKind(elements_kind) ||

IsFixedTypedArrayElementsKind(elements_kind)) {

cached_stub = LoadFastElementStub(isolate(), is_js_array, elements_kind,

convert_hole_to_undefined).GetCode();