src/compiler/access-builder.cc - Issue 1254623002: Remove ExternalArray, derived types, and element kinds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/access-builder.cc

Issue 1254623002: Remove ExternalArray, derived types, and element kinds (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/access-builder.cc

diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc

index 24701634748a363747cff0d0cc715f386bd723fe..32d14076f3d2f351052ffbfb5eba0a604a59d8ec 100644

--- a/src/compiler/access-builder.cc

+++ b/src/compiler/access-builder.cc

@@ -82,7 +82,8 @@ FieldAccess AccessBuilder::ForFixedArrayLength() {

// static

FieldAccess AccessBuilder::ForExternalArrayPointer() {

- FieldAccess access = {kTaggedBase, ExternalArray::kExternalPointerOffset,

+ FieldAccess access = {kTaggedBase,

+ FixedTypedArrayBase::kExternalPointerOffset,

MaybeHandle<Name>(), Type::UntaggedPointer(), kMachPtr};

return access;

}