Source/core/layout/LayoutVideo.cpp - Issue 1254613003: Let the WebMediaPlayer decide whether to use overlay video.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutVideo.cpp

Issue 1254613003: Let the WebMediaPlayer decide whether to use overlay video. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address Xianzhu's Comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/HTMLVideoElement.cpp ('k') | Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutVideo.cpp

diff --git a/Source/core/layout/LayoutVideo.cpp b/Source/core/layout/LayoutVideo.cpp

index 85d2caa574f58ff732e200d320932b67d8fe021f..0dc2abe3237296e7b7f4171aa333c3f346cd001e 100644

--- a/Source/core/layout/LayoutVideo.cpp

+++ b/Source/core/layout/LayoutVideo.cpp

@@ -246,11 +246,9 @@ LayoutUnit LayoutVideo::offsetHeight() const

CompositingReasons LayoutVideo::additionalCompositingReasons() const

{

- if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {

- HTMLMediaElement* media = toHTMLMediaElement(node());

- if (media->isFullscreen())

- return CompositingReasonVideo;

- }

+ HTMLMediaElement* element = toHTMLMediaElement(node());

+ if (element->isFullscreen() && element->usesOverlayFullscreenVideo())

+ return CompositingReasonVideo;

if (shouldDisplayVideo() && supportsAcceleratedRendering())

return CompositingReasonVideo;

« no previous file with comments | « Source/core/html/HTMLVideoElement.cpp ('k') | Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp » ('j') | no next file with comments »