Let the WebMediaPlayer decide whether to use overlay video.

Source/core/html/HTMLVideoElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 20 matching lines @@
 #include "core/HTMLNames.h"
 #include "core/dom/Attribute.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/frame/Settings.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 #include "core/layout/LayoutImage.h"
 #include "core/layout/LayoutVideo.h"
+#include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/ImageBuffer.h"
 #include "platform/graphics/gpu/Extensions3DUtil.h"
 #include "public/platform/WebCanvas.h"
 #include "public/platform/WebGraphicsContext3D.h"
 
 namespace blink {
 
 using namespace HTMLNames;
@@ skipping 186 matching lines @@
 bool HTMLVideoElement::webkitSupportsFullscreen()
 {
     return Fullscreen::fullscreenEnabled(document());
 }
 
 bool HTMLVideoElement::webkitDisplayingFullscreen()
 {
     return isFullscreen();
 }
 
+bool HTMLVideoElement::supportsOverlayFullscreenVideo() const
+{
+    // For WebRTC, the video frame contains all the data and no hardware surface
+    // should be used.
+    return !HTMLMediaElement::isMediaStreamURL(sourceURL().string())
+        && (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()
+            || (webMediaPlayer() && webMediaPlayer()->supportsOverlayFullscreenVideo()));

[trchen, 2015/07/30 21:29:21]

This condition feels weird to me. I'd prefer it that if
!RuntimeEnabledFeatures::overlayFullscreenVideoEnabled() we never enable the
overlay hack.

[watk, 2015/08/03 21:47:44]

I've added forceCverlayFullscreenVideo which can be used to force enable it for
virtual layout tests. I'll remove overlayFullscreenEnabled in a follow-up CL
once the Android WMP implementation is updated.

+}
+
 void HTMLVideoElement::didMoveToNewDocument(Document& oldDocument)
 {
     if (m_imageLoader)
         m_imageLoader->elementDidMoveToNewDocument();
     HTMLMediaElement::didMoveToNewDocument(oldDocument);
 }
 
 unsigned HTMLVideoElement::webkitDecodedFrameCount() const
 {
     if (!webMediaPlayer())
@@ skipping 42 matching lines @@
 {
     return !isMediaDataCORSSameOrigin(destinationSecurityOrigin);
 }
 
 FloatSize HTMLVideoElement::elementSize() const
 {
     return FloatSize(videoWidth(), videoHeight());
 }
 
 } // namespace blink