Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1254603002: Extract function to compute mutator utilization. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extract function to compute mutator utilization. This function will be used later instead of HasLowAllocationRate to decide how many pages to compact. BUG=chromium:502247 LOG=NO Committed: https://crrev.com/0752abb11453a3f1ea1d4eecf3f9068b6f599e4d Cr-Commit-Position: refs/heads/master@{#29841}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused function #

Patch Set 3 : return min mutator utilization instead of max when there is no data. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -10 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +44 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ulan
Hannes, ptal. This is just refactoring without any change in behavior.
5 years, 5 months ago (2015-07-23 14:53:45 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/1254603002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1254603002/diff/1/src/heap/heap.cc#newcode4824 src/heap/heap.cc:4824: double Heap::MutatorUtilization() { This function is not called.
5 years, 5 months ago (2015-07-24 07:44:22 UTC) #3
ulan
https://codereview.chromium.org/1254603002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1254603002/diff/1/src/heap/heap.cc#newcode4824 src/heap/heap.cc:4824: double Heap::MutatorUtilization() { On 2015/07/24 07:44:22, Hannes Payer wrote: ...
5 years, 5 months ago (2015-07-24 07:47:21 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-07-24 09:43:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254603002/20001
5 years, 5 months ago (2015-07-24 09:46:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254603002/40001
5 years, 5 months ago (2015-07-24 09:52:17 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-24 10:31:25 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 10:31:41 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0752abb11453a3f1ea1d4eecf3f9068b6f599e4d
Cr-Commit-Position: refs/heads/master@{#29841}

Powered by Google App Engine
This is Rietveld 408576698