Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 12546024: Consistently pass a Heap* to HashTable-related AsObject methods. (Closed)

Created:
7 years, 9 months ago by Sven Panne
Modified:
7 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Consistently pass a Heap* to HashTable-related AsObject methods. This is basically a follow-up CL to https://code.google.com/p/v8/source/detail?r=13908. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M src/objects.h View 9 chunks +13 lines, -13 lines 0 comments Download
M src/objects.cc View 21 chunks +30 lines, -30 lines 0 comments Download
M src/objects-inl.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 9 months ago (2013-03-12 09:05:14 UTC) #1
Yang
On 2013/03/12 09:05:14, Sven Panne wrote: LGTM.
7 years, 9 months ago (2013-03-12 09:30:55 UTC) #2
Sven Panne
7 years, 9 months ago (2013-03-12 10:05:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698