Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 12546016: Remove the Extensions URLRequestContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_browser_context.cc
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
index 51f1c17bc1707de49c746b93d583a212d57e556c..f86e5d5b7701c4a326a3d7f3e9414037d4c96586 100644
--- a/android_webview/browser/aw_browser_context.cc
+++ b/android_webview/browser/aw_browser_context.cc
@@ -108,6 +108,11 @@ void AwBrowserContext::AddVisitedURLs(const std::vector<GURL>& urls) {
net::URLRequestContextGetter* AwBrowserContext::CreateRequestContext(
content::ProtocolHandlerMap* protocol_handlers) {
+ // TODO(ajwong): The whole interaction between
+ // BrowserThreadDelegate::Init(), StoragePartition is non-standard.
+ // Usually the CookieStore is created and owned by the StoragePartition.
+ //
+ // Fix this after we clean up the cookie stores in http://crbug.com/159193
CHECK(url_request_context_getter_.get());
url_request_context_getter_->SetProtocolHandlers(protocol_handlers);
return url_request_context_getter_.get();

Powered by Google App Engine
This is Rietveld 408576698