Remove the Extensions URLRequestContext

content/public/browser/cookie_store_map.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_COOKIE_STORE_MAP_H_
+#define CONTENT_PUBLIC_BROWSER_COOKIE_STORE_MAP_H_
+
+#include <string>
+
+#include "content/common/content_export.h"
+
+namespace net {
+class CookieStore;
+}  // namespace net
+
+namespace content {
+
+// CookieStoreMap allows associating of different CookieStore objects with
+// different schemes. It is mainly a convenience class.
+class CONTENT_EXPORT CookieStoreMap {
+ public:
+  virtual ~CookieStoreMap() {}
+
+  // Returns the CookieStore associated with |scheme|.
+  virtual net::CookieStore* GetForScheme(const std::string& scheme) const = 0;

[jam, 2013/07/31 17:04:02]

i see that this is only called in chrome from unittests. i'm wondering if
there's another way for the tests to get this, and then the only thing that
chrome non-test code calls would be SetForScheme. If that's the case, then would
it be feasible to completely hide the CookieStoreMap from embedders, and replace
OverrideCookieStoreMap with a method that instead gets a vector from the
embedder for schemes that should have their own cookie stores. and if we could
do that, could we then hide content::CreateCookieStore from embedders as well?
if we could do that, then we could hide CookieStoreConfig as well (or eliminate
it altogether)

[awong, 2013/08/05 23:32:38]

Actually, it's needed by RenderMessageFilter (like 551).  If it wasn't for this,
I could probably have removed the whole map type int he public API.

[jam, 2013/08/07 06:16:32]

if it's just RMF, then we can still hide it from the content api as it's only
used internally then right?

[awong, 2013/08/08 01:23:21]

We can't just return a vector of schemes because the path, whether you share
cookie jars, and whether you have a delegate, or a special storage policy
changes need to be specified in the embedder in a fairly non-uniform way.

What I've done is create a map of CookieStoreConfigs.  I think this has allowed
me to remove this from the public API (though it's still here on the latest
patch).

+
+  // Associates a |cookie_store| with the given |scheme|. Should only be called
+  // once for any given |scheme|. |cookie_store| must be non-NULL. The
+  // CookieStoreMap will retain the |cookie_store| object.
+  virtual void SetForScheme(const std::string& scheme,
+                            net::CookieStore* cookie_store) = 0;
+
+  // Makes a clone of the map. Useful if the map needs to be copied to another
+  // thread.
+  virtual CookieStoreMap* Clone() const = 0;

[jam, 2013/07/31 17:04:02]

I only see this being called from content, so this can be just on the impl?

[awong, 2013/08/05 23:32:38]

Good point. Moved out of public API.

+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_COOKIE_STORE_MAP_H_