Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1254573002: Version 4.4.63.24 (cherry-pick) (Closed)

Created:
5 years, 5 months ago by jbramley
Modified:
5 years, 4 months ago
Reviewers:
Michael Hablich
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.4
Target Ref:
refs/pending/branch-heads/4.4
Project:
v8
Visibility:
Public.

Description

Version 4.4.63.24 (cherry-pick) Merged 6802c4b921fdc717227fec996e6988ff12a93c1b Merged d05538827e32ebfed5297653266d65c11e438148 Merged 879550ce0f8d3cffb519440101a4026635bc6026 Merged 3c9c7748c386d967762116de53e31dd1d24f8627 Merged bfe700b8edfe68e8c5f05d408f71168096bc2e1a [arm] Remove unused jump_elimination_allowed parameter to Assembler::branch_offset(). [arm] Fix missing CheckBuffer for branches. [arm] Don't call branch_offset within CheckConstPool. [arm] CheckConstPool between TurboFan instructions. Use a label-branch in CheckConstPool. BUG=v8:4292, v8:4292, v8:4292 LOG=N NOTRY=true R=hablich@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -14 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.h View 3 chunks +12 lines, -8 lines 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +21 lines, -2 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jbramley
5 years, 5 months ago (2015-07-23 10:57:15 UTC) #1
Michael Hablich
On 2015/07/23 10:57:15, jbramley wrote: lgtm, ignore these trybot results because they don't work on ...
5 years, 5 months ago (2015-07-23 12:13:16 UTC) #4
jbramley
5 years, 5 months ago (2015-07-23 12:16:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b4cb37cb41357c16b25abdabc894aaa8fc78021.

Powered by Google App Engine
This is Rietveld 408576698