Change exclusive access popup behaviour with simplified-fullscreen-ui.

chrome/browser/ui/exclusive_access/exclusive_access_bubble.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_BUBBLE_H_
 #define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_BUBBLE_H_
 
 #include "base/timer/timer.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h"
 #include "ui/gfx/animation/animation_delegate.h"
@@ skipping 13 matching lines @@
  public:
   explicit ExclusiveAccessBubble(ExclusiveAccessManager* manager,
                                  const GURL& url,
                                  ExclusiveAccessBubbleType bubble_type);
   ~ExclusiveAccessBubble() override;
 
  protected:
   static const int kPaddingPx;        // Amount of padding around the link
   static const int kInitialDelayMs;   // Initial time bubble remains onscreen
   static const int kIdleTimeMs;       // Time before mouse idle triggers hide
+  // Time to show initial message (simplified fullscreen UI).
+  static const int kInitialDebounceTimeMs;
+  // Time to re-notify user (simplified fullscreen UI).
+  static const int kRenotifyTimeMs;

[scheib, 2015/08/04 19:36:28]

kRenotifyTimeM -> kSnoozeNotificationsTimeMs
And comment:
// Time to wait and suppress notifications because we have recently 
// shown one and expect the user remembers. Notifications will not be
// shown again until this amount of time has passed and then the user
// interacts in a way that causes a notification to be shown.

Perhaps make move this explanation up to a larger design comment at top of file,
and have references, "See Notification Display Design Note above." here and
below.

[Matt Giuca, 2015/08/05 03:27:20]

Done.

[scheib, 2015/08/05 05:24:19]

Thanks. OK to leave like this, but BTW I think it's OK to move entire comment
contents here (and below for the timer) to the note at the top and just have a
brief // See "Design Note" above.

[Matt Giuca, 2015/08/06 03:33:03]

Done.

   static const int kPositionCheckHz;  // How fast to check the mouse position
   static const int kSlideInRegionHeightPx;
   // Height of region triggering
   // slide-in
   static const int kPopupTopPx;          // Space between the popup and the top
                                          // of the screen.
   static const int kSlideInDurationMs;   // Duration of slide-in animation
   static const int kSlideOutDurationMs;  // Duration of slide-out animation
 
   // Returns the current desirable rect for the popup window.  If
@@ skipping 44 matching lines @@
   // The Manager associated with this bubble.
   ExclusiveAccessManager* const manager_;
 
   // The host the bubble is for, can be empty.
   GURL url_;
 
   // The type of the bubble; controls e.g. which buttons to show.
   ExclusiveAccessBubbleType bubble_type_;
 
  private:
-  // Timer to delay before allowing the bubble to hide after it's initially
-  // shown.
-  base::OneShotTimer<ExclusiveAccessBubble> initial_delay_;
+  // When this timer is active, prevent the bubble from hiding. This ensures it
+  // will be displayed for a minimum amount of time (which can be extended by
+  // the user moving the mouse to the top of the screen and holding it there).
+  base::OneShotTimer<ExclusiveAccessBubble> hide_timeout_;
 
   // Timer to see how long the mouse has been idle.
   base::OneShotTimer<ExclusiveAccessBubble> idle_timeout_;
 
+  // When this timer has elapsed, we will aggressively notify the user about

[msw, 2015/08/04 18:21:51]

What's aggressive about this? Remove 'aggressive' from the comment & identifier.
Maybe say below "on the next mouse input, regardless of the mouse location".

[Matt Giuca, 2015/08/05 03:27:20]

Done. (And renamed to suppress_notify_timeout_).

+  // currently active exclusive access (on the next mouse/keyboard input). While

[msw, 2015/08/04 18:21:51]

nit: no keyboard...

[Matt Giuca, 2015/08/05 03:27:20]

Done.

[scheib, 2015/08/05 05:24:19]

Long term we'd want keyboard too, though, right?

[Matt Giuca, 2015/08/06 03:33:03]

Yeah. I originally had that comment there because that was the plan, but I think
msw is right and we want the comments to accurately reflect the current
behaviour.

+  // the timer is ticking, we do not notify unless the user mouses to the top of

[scheib, 2015/08/04 19:36:28]

Mouse location should have no impact on notification display. Explanation added
to design doc:
https://docs.google.com/document/d/10Hm6dstWEY9sOdbENijz70I6Tnbz91mPkNKeteMJ-...

[Matt Giuca, 2015/08/05 03:27:20]

Done.

[Matt Giuca, 2015/08/05 03:35:08]

Oh sorry, by "Done" I mean "not done" (just updated comment).

Current behaviour is mouse to top will re-show the bubble. I'll change this but
I want to do this incrementally and not make too big of a CL here. Mind if I
postpone this?

[scheib, 2015/08/05 05:24:19]

Acknowledged. Follow patch is fine.

+  // the screen.
+  //
+  // This has two uses: 1. a short debounce period when first entering exclusive
+  // access (so we do not immediately notify the user), and 2. a very long
+  // period after already notifying the user once, to re-notify them.
+  base::OneShotTimer<ExclusiveAccessBubble> aggressive_notify_timeout_;
+
   // Timer to poll the current mouse position.  We can't just listen for mouse
   // events without putting a non-empty HWND onscreen (or hooking Windows, which
   // has other problems), so instead we run a low-frequency poller to see if the
   // user has moved in or out of our show/hide regions.
   base::RepeatingTimer<ExclusiveAccessBubble> mouse_position_checker_;
 
   // The most recently seen mouse position, in screen coordinates.  Used to see
   // if the mouse has moved since our last check.
   gfx::Point last_mouse_pos_;
 
   DISALLOW_COPY_AND_ASSIGN(ExclusiveAccessBubble);
 };
 
 #endif  // CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_BUBBLE_H_