runtime/vm/disassembler_x64.cc - Issue 12545067: On x64 use 32bit idiv when possible instead of 64bit one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_x64.cc

Issue 12545067: On x64 use 32bit idiv when possible instead of 64bit one. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rename movsxl to movsxd Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_x64.cc

diff --git a/runtime/vm/disassembler_x64.cc b/runtime/vm/disassembler_x64.cc

index e17c4f0b82542b55f066912efed40bbdf6258615..4af7ba3f07d406fe6205e4d5b3b806b7fd76a3e6 100644

--- a/runtime/vm/disassembler_x64.cc

+++ b/runtime/vm/disassembler_x64.cc

@@ -70,7 +70,7 @@ static const ByteMnemonic two_operands_instr[] = {

{ 0x39, OPER_REG_OP_ORDER, "cmp" },

{ 0x3A, BYTE_REG_OPER_OP_ORDER, "cmp" },

{ 0x3B, REG_OPER_OP_ORDER, "cmp" },

- { 0x63, REG_OPER_OP_ORDER, "movsxlq" },

+ { 0x63, REG_OPER_OP_ORDER, "movsxd" },

{ 0x84, BYTE_REG_OPER_OP_ORDER, "test" },

{ 0x85, REG_OPER_OP_ORDER, "test" },

{ 0x86, BYTE_REG_OPER_OP_ORDER, "xchg" },

« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »