Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 12545067: On x64 use 32bit idiv when possible instead of 64bit one. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix optimized pattern for kTRUNCDIV as well Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64_test.cc
diff --git a/runtime/vm/assembler_x64_test.cc b/runtime/vm/assembler_x64_test.cc
index 1287571390502b17f76b85497edbc4bc013172fe..5bdfbe114ed1b7da9accc7222085ad23e6d3f315 100644
--- a/runtime/vm/assembler_x64_test.cc
+++ b/runtime/vm/assembler_x64_test.cc
@@ -515,6 +515,22 @@ ASSEMBLER_TEST_RUN(MoveExtend, test) {
}
+ASSEMBLER_TEST_GENERATE(MoveExtend32, assembler) {
+ __ movq(RDX, Immediate(0xffffffff));
+ __ movsxl(RDX, RDX);
+ __ movq(RAX, Immediate(0x7fffffff));
+ __ movsxl(RAX, RAX);
+ __ addq(RAX, RDX);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(MoveExtend32, test) {
+ typedef intptr_t (*MoveExtend)();
+ EXPECT_EQ(0x7ffffffe, reinterpret_cast<MoveExtend>(test->entry())());
+}
+
+
ASSEMBLER_TEST_GENERATE(MoveExtendMemory, assembler) {
__ movq(RDX, Immediate(0x123456781234ffff));

Powered by Google App Engine
This is Rietveld 408576698