Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/dom/src/EventStreamProvider.dart

Issue 12545056: Make stream subscription more lax wrt. calling methods on it after it's completed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/EventStreamProvider.dart
diff --git a/tools/dom/src/EventStreamProvider.dart b/tools/dom/src/EventStreamProvider.dart
index a74e998ea816542d8bf6409af38891ab5d694bf8..f5a9407eb6f561119befa2069eedc43528734ff0 100644
--- a/tools/dom/src/EventStreamProvider.dart
+++ b/tools/dom/src/EventStreamProvider.dart
@@ -41,9 +41,7 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
}
void cancel() {
- if (_canceled) {
- throw new StateError("Subscription has been canceled.");
- }
+ if (_canceled) return;
_unlisten();
// Clear out the target to indicate this is complete.
@@ -71,9 +69,7 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
void onDone(void handleDone()) {}
void pause([Future resumeSignal]) {
- if (_canceled) {
- throw new StateError("Subscription has been canceled.");
- }
+ if (_canceled) return;
++_pauseCount;
_unlisten();
@@ -85,12 +81,7 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
bool get _paused => _pauseCount > 0;
void resume() {
- if (_canceled) {
- throw new StateError("Subscription has been canceled.");
- }
- if (!_paused) {
- throw new StateError("Subscription is not paused.");
- }
+ if (_canceled || !_paused) return;
--_pauseCount;
_tryResume();
}
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698