ui/views/bubble/bubble_frame_view.cc - Issue 12545040: A couple of fixes to bubble view:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 12545040: A couple of fixes to bubble view: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.cc

diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc

index c7efa375752b4bdf136e9b9fab0f99b84bc18b16..5e6d11a21b9189c073aae335f4307a73e4376efc 100644

--- a/ui/views/bubble/bubble_frame_view.cc

+++ b/ui/views/bubble/bubble_frame_view.cc

@@ -184,6 +184,10 @@ gfx::Rect BubbleFrameView::GetUpdatedWindowBounds(const gfx::Rect& anchor_rect,

MirrorArrowIfOffScreen(true, anchor_rect, client_size);

MirrorArrowIfOffScreen(false, anchor_rect, client_size);

} else {

+ // Mirror as needed vertically if the arrow is on a horizontal edge and

+ // vice-versa.

+ MirrorArrowIfOffScreen(BubbleBorder::is_arrow_on_horizontal(arrow),

+ anchor_rect, client_size);

msw 2013/03/14 20:59:44 nit: indent to match the open paren above.

varunjain 2013/03/14 21:15:08 Done.

OffsetArrowIfOffScreen(anchor_rect, client_size);

}

« no previous file with comments | « ui/views/bubble/bubble_delegate.cc ('k') | ui/views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »