Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 125443002: In-app messaging to communicate the imminent 32-bit deprecation to 32-bit-only users (Closed)

Created:
6 years, 11 months ago by Mark Mentovai
Modified:
6 years, 11 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

In-app messaging to communicate the imminent 32-bit deprecation to 32-bit-only users. In Google Chrome-branded builds, show an infobar at startup to users with 32-bit-only systems, and add a message to the about page for those users advising that automatic updates will soon stop because the system configuration is about to become unsupported. A provision is made to change this message to an "end-of-the-line" message for the final 32-bit-compatible build. When this switch is flipped, the autoupdate status and promotion button on the about page will be hidden. The "end-of-the-line" message will appear there, alongside the icon normally used for failed updates. The startup infobar text will change at that point as well. No observable changes for non-branded Chromium builds (since they're not receiving updates through this mechanism) or for users with 64-bit-capable systems (because they're not being obsoleted). R=arv@chromium.org, thakis@chromium.org, thakis BUG=303280, 331810, 331830 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245598

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -150 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 1 2 3 4 5 6 7 5 chunks +2 lines, -19 lines 0 comments Download
A chrome/browser/mac/obsolete_system.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/mac/obsolete_system.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/resources/help/help.html View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/help/help.js View 1 2 3 4 5 6 7 8 3 chunks +39 lines, -2 lines 0 comments Download
D chrome/browser/ui/startup/obsolete_os_infobar_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/startup/obsolete_os_infobar_delegate.cc View 1 chunk +0 lines, -69 lines 0 comments Download
A + chrome/browser/ui/startup/obsolete_system_infobar_delegate.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 1 2 chunks +29 lines, -11 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 3 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_mac.mm View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mark Mentovai
I’m done with most of the work here except for the strings and URL, but ...
6 years, 11 months ago (2014-01-06 22:10:15 UTC) #1
Nico
lgtm https://codereview.chromium.org/125443002/diff/30001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/125443002/diff/30001/chrome/app/chromium_strings.grd#newcode353 chrome/app/chromium_strings.grd:353: This computer will soon stop receiving updates of ...
6 years, 11 months ago (2014-01-07 00:51:37 UTC) #2
Mark Mentovai
https://codereview.chromium.org/125443002/diff/30001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/125443002/diff/30001/chrome/app/chromium_strings.grd#newcode353 chrome/app/chromium_strings.grd:353: This computer will soon stop receiving updates of Chromium ...
6 years, 11 months ago (2014-01-07 17:55:38 UTC) #3
Mark Mentovai
+arv for chrome/browser/ui/webui and chrome/browser/resources.
6 years, 11 months ago (2014-01-07 19:32:23 UTC) #4
Mark Mentovai
Strings updated per bug 331830.
6 years, 11 months ago (2014-01-09 16:50:40 UTC) #5
arv (Not doing code reviews)
js,html,grd LGTM
6 years, 11 months ago (2014-01-09 19:06:07 UTC) #6
Mark Mentovai
This change is still held up waiting for a help center doc, so I broke ...
6 years, 11 months ago (2014-01-10 21:33:00 UTC) #7
Mark Mentovai
6 years, 11 months ago (2014-01-17 20:30:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #10 manually as r245598 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698