Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 12544030: Chromium side plumbing for enabling fixed root background compositing. (Closed)

Created:
7 years, 9 months ago by Ian Vollick
Modified:
7 years, 5 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, klobag.chromium
Visibility:
Public.

Description

Chromium side plumbing for enabling fixed root background compositing. Adds --enable-accelerated-fixed-root-background and related plumbing. Depends on wkb.ug/112865 TBR=sky@chromium.org BUG=180885 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210416

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Ian Vollick
+jamesr for webkit/ +piman for content/ +sky for chrome/
7 years, 9 months ago (2013-03-21 02:03:09 UTC) #1
jamesr
lgtm
7 years, 9 months ago (2013-03-21 02:04:47 UTC) #2
jamesr
Either on this patch or on the WebKit one we need to make sure we ...
7 years, 9 months ago (2013-03-21 02:05:59 UTC) #3
piman
lgtm
7 years, 9 months ago (2013-03-21 02:12:36 UTC) #4
Ian Vollick
+aelias On 2013/03/21 02:05:59, jamesr wrote: > Either on this patch or on the WebKit ...
7 years, 9 months ago (2013-03-22 17:47:10 UTC) #5
aelias_OOO_until_Jul13
Yes, we decided it to turn it off because we couldn't handle all the invalidates ...
7 years, 9 months ago (2013-03-22 20:33:35 UTC) #6
Ian Vollick
On 2013/03/22 20:33:35, aelias wrote: > Yes, we decided it to turn it off because ...
7 years, 6 months ago (2013-06-06 17:21:44 UTC) #7
aelias_OOO_until_Jul13
On 2013/06/06 17:21:44, vollick wrote: > - The setting is enabled by default on high-DPI ...
7 years, 6 months ago (2013-06-06 19:18:45 UTC) #8
Ian Vollick
On 2013/06/06 19:18:45, aelias wrote: > On 2013/06/06 17:21:44, vollick wrote: > > - The ...
7 years, 5 months ago (2013-07-03 18:51:46 UTC) #9
Ian Vollick
On 2013/07/03 18:51:46, vollick wrote: > On 2013/06/06 19:18:45, aelias wrote: > > On 2013/06/06 ...
7 years, 5 months ago (2013-07-03 18:52:23 UTC) #10
aelias_OOO_until_Jul13
OK, lgtm! We're quite far from M30 branch point so I'm fine with trying to ...
7 years, 5 months ago (2013-07-08 01:03:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/12544030/16001
7 years, 5 months ago (2013-07-08 03:46:13 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-08 04:20:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/12544030/16001
7 years, 5 months ago (2013-07-08 17:22:12 UTC) #14
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-08 17:24:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/12544030/16001
7 years, 5 months ago (2013-07-08 19:36:37 UTC) #16
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 21:07:26 UTC) #17
Message was sent while issue was closed.
Change committed as 210416

Powered by Google App Engine
This is Rietveld 408576698