Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 12544021: Fix bug 9090: provide the paramter checks arguments to the generative constructor body after the re… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/argument_definition6_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 19909)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -1477,12 +1477,18 @@
FunctionSignature functionSignature = body.computeSignature(compiler);
+ // Provide the parameters to the generative constructor body.
functionSignature.orderedForEachParameter((parameter) {
- // if [parameter] is boxed, it will be a field in the box passed as the
- // last parameter. So no need to direclty pass it.
+ // If [parameter] is boxed, it will be a field in the box passed as the
+ // last parameter. So no need to directly pass it.
if (!localsHandler.isBoxed(parameter)) {
bodyCallInputs.add(localsHandler.readLocal(parameter));
}
+ });
+
+ // Provide the parameter checks to the generative constructor
+ // body.
+ functionSignature.orderedForEachParameter((parameter) {
// If [parameter] is checked, we pass the already computed
// boolean to the constructor body.
if (elements.isParameterChecked(parameter)) {
« no previous file with comments | « no previous file | tests/language/argument_definition6_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698