Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: runtime/vm/snapshot.cc

Issue 12544015: Implement 'dart:typeddata' directly in the VM instead of using 'dart:scalarlist' (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | tests/standalone/typed_array_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
===================================================================
--- runtime/vm/snapshot.cc (revision 19652)
+++ runtime/vm/snapshot.cc (working copy)
@@ -33,7 +33,9 @@
// Check if this is a class which is stored in the object store.
return (class_id == kObjectCid ||
(class_id >= kInstanceCid && class_id <= kWeakPropertyCid) ||
- RawObject::IsStringClassId(class_id));
+ RawObject::IsStringClassId(class_id) ||
+ RawObject::IsTypedDataClassId(class_id) ||
+ RawObject::IsExternalTypedDataClassId(class_id));
}
@@ -312,6 +314,13 @@
}
CLASS_LIST_NO_OBJECT(SNAPSHOT_READ)
#undef SNAPSHOT_READ
+#define SNAPSHOT_READ(clazz) \
+ case kTypedData##clazz##Cid: { \
+ obj_ = TypedData::ReadFrom(this, object_id, tags, kind_); \
+ break; \
+ }
+ CLASS_LIST_TYPED_DATA(SNAPSHOT_READ)
+#undef SNAPSHOT_READ
default: UNREACHABLE(); break;
}
if (kind_ == Snapshot::kFull) {
@@ -448,7 +457,7 @@
ASSERT(isolate()->no_gc_scope_depth() != 0);
if (class_id < kNumPredefinedCids) {
ASSERT((class_id >= kInstanceCid) &&
- (class_id <= kExternalTwoByteStringCid));
+ (class_id <= kExternalTypedDataFloat64ArrayCid));
return isolate()->class_table()->At(class_id);
}
cls_ = Object::class_class();
@@ -784,6 +793,13 @@
}
CLASS_LIST_NO_OBJECT(SNAPSHOT_READ)
#undef SNAPSHOT_READ
+#define SNAPSHOT_READ(clazz) \
+ case kTypedData##clazz##Cid: { \
+ obj_ = TypedData::ReadFrom(this, object_id, tags, kind_); \
+ break; \
+ }
+ CLASS_LIST_TYPED_DATA(SNAPSHOT_READ)
+#undef SNAPSHOT_READ
default: UNREACHABLE(); break;
}
if (kind_ == Snapshot::kFull) {
@@ -977,6 +993,21 @@
CLASS_LIST_NO_OBJECT(SNAPSHOT_WRITE)
#undef SNAPSHOT_WRITE
+#define SNAPSHOT_WRITE(clazz) \
+ case kTypedData##clazz##Cid: { \
+ RawTypedData* raw_obj = reinterpret_cast<RawTypedData*>(raw); \
+ raw_obj->WriteTo(this, object_id, kind_); \
+ return; \
+ } \
+ case kExternalTypedData##clazz##Cid: { \
+ RawExternalTypedData* raw_obj = \
+ reinterpret_cast<RawExternalTypedData*>(raw); \
+ raw_obj->WriteTo(this, object_id, kind_); \
+ return; \
+ } \
+
+ CLASS_LIST_TYPED_DATA(SNAPSHOT_WRITE)
+#undef SNAPSHOT_WRITE
default: break;
}
UNREACHABLE();
@@ -1207,6 +1238,21 @@
CLASS_LIST_NO_OBJECT(SNAPSHOT_WRITE)
#undef SNAPSHOT_WRITE
+#define SNAPSHOT_WRITE(clazz) \
+ case kTypedData##clazz##Cid: { \
+ RawTypedData* raw_obj = reinterpret_cast<RawTypedData*>(raw); \
+ raw_obj->WriteTo(this, object_id, kind_); \
+ return; \
+ } \
+ case kExternalTypedData##clazz##Cid: { \
+ RawExternalTypedData* raw_obj = \
+ reinterpret_cast<RawExternalTypedData*>(raw); \
+ raw_obj->WriteTo(this, object_id, kind_); \
+ return; \
+ } \
+
+ CLASS_LIST_TYPED_DATA(SNAPSHOT_WRITE)
+#undef SNAPSHOT_WRITE
default: break;
}
UNREACHABLE();
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | tests/standalone/typed_array_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698