Gyp changes for NaCl debugger

Gyp changes for NaCl debugger
Committed: https://code.google.com/p/skia/source/detail?r=8015

[borenet, 2013-03-06 21:41:16]

Enables https://codereview.chromium.org/12545007

[djsollen, 2013-03-07 15:04:48]

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp
File trunk/gyp/debugger.gyp (right):

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp#newcod...
trunk/gyp/debugger.gyp:164: 'targets': [
why does this need to be in a condition?

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/images.gyp
File trunk/gyp/images.gyp (right):

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/images.gyp#newcode109
trunk/gyp/images.gyp:109: '-lz',
why do we need this?

[borenet, 2013-03-07 15:09:11]

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp
File trunk/gyp/debugger.gyp (right):

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp#newcod...
trunk/gyp/debugger.gyp:164: 'targets': [
On 2013/03/07 15:04:48, djsollen wrote:
> why does this need to be in a condition?

I like the safety of having the target not exist unless it can be built.  I can
remove the conditional if you think it's better that way, since it isn't
required.

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/images.gyp
File trunk/gyp/images.gyp (right):

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/images.gyp#newcode109
trunk/gyp/images.gyp:109: '-lz',
On 2013/03/07 15:04:48, djsollen wrote:
> why do we need this?

libpng depends on zlib.  Apparently this dependency is resolved elsewhere for
normal desktop builds, but NaCl needs it to be explicit.

[djsollen, 2013-03-07 15:13:28]

lgtm with my one nit.

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp
File trunk/gyp/debugger.gyp (right):

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp#newcod...
trunk/gyp/debugger.gyp:164: 'targets': [
I would remove it from the conditional. Perhaps you can make the target_name
reflect that this is QT specific.

[borenet, 2013-03-07 15:21:10]

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp
File trunk/gyp/debugger.gyp (right):

https://codereview.chromium.org/12544011/diff/1/trunk/gyp/debugger.gyp#newcod...
trunk/gyp/debugger.gyp:164: 'targets': [
On 2013/03/07 15:13:28, djsollen wrote:
> I would remove it from the conditional. Perhaps you can make the target_name
> reflect that this is QT specific.

Per our live discussion, I left it in the conditional but renamed the target to
make its qt-ness clearer.

[borenet, 2013-03-07 15:33:32]

Committed patchset #2 manually as r8015 (presubmit successful).