mojo/common/tracing_impl.cc - Issue 1254383016: ApplicationConnection lifetime management changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/tracing_impl.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/common/tracing_impl.cc

diff --git a/mojo/common/tracing_impl.cc b/mojo/common/tracing_impl.cc

index a8d2f3608f48b16b2e6583d8510a0627a46e1e6d..4632930057d6cbfdcf5e7d20f26d655e68f880b9 100644

--- a/mojo/common/tracing_impl.cc

+++ b/mojo/common/tracing_impl.cc

@@ -20,8 +20,8 @@ TracingImpl::~TracingImpl() {

void TracingImpl::Initialize(ApplicationImpl* app) {

mojo::URLRequestPtr request(mojo::URLRequest::New());

request->url = mojo::String::From("mojo:tracing");

- ApplicationConnection* connection = app->ConnectToApplication(request.Pass());

- connection->AddService(this);

+ connection_ = app->ConnectToApplication(request.Pass());

+ connection_->AddService(this);

}

void TracingImpl::Create(ApplicationConnection* connection,

« no previous file with comments | « mojo/common/tracing_impl.h ('k') | mojo/mojo_base.gyp » ('j') | no next file with comments »