Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: mandoline/ui/browser/desktop/desktop_ui.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/browser/desktop/desktop_ui.h ('k') | media/mojo/services/media_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/ui/browser/desktop/desktop_ui.cc
diff --git a/mandoline/ui/browser/desktop/desktop_ui.cc b/mandoline/ui/browser/desktop/desktop_ui.cc
index 889ee6459e578bc077ff6308c0ab4114d1266054..2e5737cb1d8a8bca5478ea0afc9d0cbc9ea997dd 100644
--- a/mandoline/ui/browser/desktop/desktop_ui.cc
+++ b/mandoline/ui/browser/desktop/desktop_ui.cc
@@ -151,10 +151,10 @@ void DesktopUI::ButtonPressed(views::Button* sender, const ui::Event& event) {
DCHECK(!client_binding_.is_bound());
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From("mojo:omnibox");
- mojo::ApplicationConnection* application_connection =
+ omnibox_connection_ =
application_impl_->ConnectToApplication(request.Pass());
- application_connection->AddService<ViewEmbedder>(browser_);
- application_connection->ConnectToService(&omnibox_);
+ omnibox_connection_->AddService<ViewEmbedder>(browser_);
+ omnibox_connection_->ConnectToService(&omnibox_);
OmniboxClientPtr client;
client_binding_.Bind(&client);
omnibox_->SetClient(client.Pass());
« no previous file with comments | « mandoline/ui/browser/desktop/desktop_ui.h ('k') | media/mojo/services/media_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698