components/html_viewer/html_document_application_delegate.cc - Issue 1254383016: ApplicationConnection lifetime management changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/html_document_application_delegate.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/html_viewer/html_document_application_delegate.cc

diff --git a/components/html_viewer/html_document_application_delegate.cc b/components/html_viewer/html_document_application_delegate.cc

index 68eff9f5d35a8f84b922fbca684b832d9cbc559e..935f5eec5dcaeb8046d2fb3886d0141a66cbf55e 100644

--- a/components/html_viewer/html_document_application_delegate.cc

+++ b/components/html_viewer/html_document_application_delegate.cc

@@ -115,7 +115,7 @@ void HTMLDocumentApplicationDelegate::OnTerminate() {

void HTMLDocumentApplicationDelegate::Initialize(mojo::ApplicationImpl* app) {

mojo::URLRequestPtr request(mojo::URLRequest::New());

request->url = mojo::String::From("mojo:network_service");

- mojo::ApplicationConnection* connection =

+ scoped_ptr<mojo::ApplicationConnection> connection =

app_.ConnectToApplication(request.Pass());

connection->ConnectToService(&network_service_);

connection->ConnectToService(&url_loader_factory_);