mandoline/ui/browser/desktop/desktop_ui.cc - Issue 1254383016: ApplicationConnection lifetime management changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/browser/desktop/desktop_ui.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mandoline/ui/browser/desktop/desktop_ui.cc

diff --git a/mandoline/ui/browser/desktop/desktop_ui.cc b/mandoline/ui/browser/desktop/desktop_ui.cc

index 889ee6459e578bc077ff6308c0ab4114d1266054..2e5737cb1d8a8bca5478ea0afc9d0cbc9ea997dd 100644

--- a/mandoline/ui/browser/desktop/desktop_ui.cc

+++ b/mandoline/ui/browser/desktop/desktop_ui.cc

@@ -151,10 +151,10 @@ void DesktopUI::ButtonPressed(views::Button* sender, const ui::Event& event) {

DCHECK(!client_binding_.is_bound());

mojo::URLRequestPtr request(mojo::URLRequest::New());

request->url = mojo::String::From("mojo:omnibox");

- mojo::ApplicationConnection* application_connection =

+ omnibox_connection_ =

application_impl_->ConnectToApplication(request.Pass());

- application_connection->AddService<ViewEmbedder>(browser_);

- application_connection->ConnectToService(&omnibox_);

+ omnibox_connection_->AddService<ViewEmbedder>(browser_);

+ omnibox_connection_->ConnectToService(&omnibox_);

OmniboxClientPtr client;

client_binding_.Bind(&client);

omnibox_->SetClient(client.Pass());