Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: mandoline/ui/browser/desktop/desktop_ui.cc

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mandoline/ui/browser/desktop/desktop_ui.cc
diff --git a/mandoline/ui/browser/desktop/desktop_ui.cc b/mandoline/ui/browser/desktop/desktop_ui.cc
index 889ee6459e578bc077ff6308c0ab4114d1266054..de42e480de5090a1ea91163fd8758d9b4e847a69 100644
--- a/mandoline/ui/browser/desktop/desktop_ui.cc
+++ b/mandoline/ui/browser/desktop/desktop_ui.cc
@@ -151,7 +151,7 @@ void DesktopUI::ButtonPressed(views::Button* sender, const ui::Event& event) {
DCHECK(!client_binding_.is_bound());
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From("mojo:omnibox");
- mojo::ApplicationConnection* application_connection =
+ scoped_ptr<mojo::ApplicationConnection> application_connection =
sky 2015/08/11 18:28:04 Because you're putting this connection in a scoped
application_impl_->ConnectToApplication(request.Pass());
application_connection->AddService<ViewEmbedder>(browser_);
application_connection->ConnectToService(&omnibox_);

Powered by Google App Engine
This is Rietveld 408576698