Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: mandoline/tab/frame_connection.h

Issue 1254383016: ApplicationConnection lifetime management changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MANDOLINE_TAB_FRAME_CONNECTION_H_ 5 #ifndef MANDOLINE_TAB_FRAME_CONNECTION_H_
6 #define MANDOLINE_TAB_FRAME_CONNECTION_H_ 6 #define MANDOLINE_TAB_FRAME_CONNECTION_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h"
9 #include "components/view_manager/public/interfaces/view_manager.mojom.h" 10 #include "components/view_manager/public/interfaces/view_manager.mojom.h"
10 #include "mandoline/tab/frame_user_data.h" 11 #include "mandoline/tab/frame_user_data.h"
11 #include "mandoline/tab/public/interfaces/frame_tree.mojom.h" 12 #include "mandoline/tab/public/interfaces/frame_tree.mojom.h"
12 #include "mojo/services/network/public/interfaces/url_loader.mojom.h" 13 #include "mojo/services/network/public/interfaces/url_loader.mojom.h"
13 14
14 namespace mojo { 15 namespace mojo {
15 class ApplicationConnection; 16 class ApplicationConnection;
16 class ApplicationImpl; 17 class ApplicationImpl;
17 } 18 }
18 19
19 namespace mandoline { 20 namespace mandoline {
20 21
21 // FrameConnection is a FrameUserData that manages the connection to a 22 // FrameConnection is a FrameUserData that manages the connection to a
22 // particular frame. It is also responsible for obtaining the necessary 23 // particular frame. It is also responsible for obtaining the necessary
23 // services from the remote side. 24 // services from the remote side.
24 class FrameConnection : public FrameUserData { 25 class FrameConnection : public FrameUserData {
25 public: 26 public:
26 FrameConnection(); 27 FrameConnection();
27 ~FrameConnection() override; 28 ~FrameConnection() override;
28 29
29 void Init(mojo::ApplicationImpl* app, 30 void Init(mojo::ApplicationImpl* app,
30 mojo::URLRequestPtr request, 31 mojo::URLRequestPtr request,
31 mojo::ViewManagerClientPtr* view_manage_client); 32 mojo::ViewManagerClientPtr* view_manage_client);
32 33
33 FrameTreeClient* frame_tree_client() { return frame_tree_client_.get(); } 34 FrameTreeClient* frame_tree_client() { return frame_tree_client_.get(); }
34 35
35 mojo::ApplicationConnection* application_connection() { 36 mojo::ApplicationConnection* application_connection() {
36 return application_connection_; 37 return application_connection_.get();
37 } 38 }
38 39
39 private: 40 private:
40 FrameTreeClientPtr frame_tree_client_; 41 FrameTreeClientPtr frame_tree_client_;
41 42
42 // TODO(sky): needs to be destroyed when connection lost. 43 // TODO(sky): needs to be destroyed when connection lost.
43 mojo::ApplicationConnection* application_connection_; 44 scoped_ptr<mojo::ApplicationConnection> application_connection_;
44 45
45 DISALLOW_COPY_AND_ASSIGN(FrameConnection); 46 DISALLOW_COPY_AND_ASSIGN(FrameConnection);
46 }; 47 };
47 48
48 } // namespace mandoline 49 } // namespace mandoline
49 50
50 #endif // MANDOLINE_TAB_FRAME_CONNECTION_H_ 51 #endif // MANDOLINE_TAB_FRAME_CONNECTION_H_
OLDNEW
« no previous file with comments | « components/view_manager/view_manager_service_apptest.cc ('k') | mandoline/ui/browser/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698