chrome/browser/extensions/chrome_app_sorting.h - Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_app_sorting.h

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review1 Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/chrome_app_sorting.h

diff --git a/chrome/browser/extensions/chrome_app_sorting.h b/chrome/browser/extensions/chrome_app_sorting.h

index 2754bc0baaaec978bd273757fbf266e7d40e001f..29f0927c2f88216961089057e3dc795fe812c998 100644

--- a/chrome/browser/extensions/chrome_app_sorting.h

+++ b/chrome/browser/extensions/chrome_app_sorting.h

@@ -27,8 +27,6 @@ class ChromeAppSorting : public AppSorting {

~ChromeAppSorting() override;

// AppSorting implementation:

- void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override;

- void CheckExtensionScopedPrefs() const override;

void Initialize(const extensions::ExtensionIdList& extension_ids) override;

void FixNTPOrdinalCollisions() override;

void EnsureValidOrdinals(

@@ -152,7 +150,6 @@ class ChromeAppSorting : public AppSorting {

// Returns the number of items in |m| visible on the new tab page.

size_t CountItemsVisibleOnNtp(const AppLaunchOrdinalMap& m) const;

- ExtensionScopedPrefs* extension_scoped_prefs_; // Weak, owns this instance.

content::BrowserContext* browser_context_;

// A map of all the StringOrdinal page ordinals mapping to the collections of

« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | extensions/browser/extension_prefs.cc » ('J')