Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: extensions/browser/app_sorting.h

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing include Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_sorting.h
diff --git a/extensions/browser/app_sorting.h b/extensions/browser/app_sorting.h
index 3ab4c80c51d1f17ebc406ef7c04dea37e53a736f..303fc9ae3b6fa7154894be99d56d79e9b5b172ea 100644
--- a/extensions/browser/app_sorting.h
+++ b/extensions/browser/app_sorting.h
@@ -21,19 +21,6 @@ class AppSorting {
AppSorting() {}
virtual ~AppSorting() {}
- // Sets the object used to look up preferences. Ownership remains with the
- // caller.
- virtual void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) = 0;
-
- // CHECKs that SetExtensionScopedPrefs has been called with a non-null object.
- // TODO(mgiuca): Added this to try and diagnose http://crbug.com/476648.
- // Remove it after the investigation is concluded.
- virtual void CheckExtensionScopedPrefs() const = 0;
-
- // Properly initializes internal values that require |extension_ids|.
- // SetExtensionScopedPrefs must have been called prior to this.
- virtual void Initialize(const extensions::ExtensionIdList& extension_ids) = 0;
-
// Resolves any conflicts the might be created as a result of syncing that
// results in two icons having the same page and app launch ordinal. After
// this is called it is guaranteed that there are no collisions of NTP icons.
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | extensions/browser/app_window/app_window_geometry_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698