Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4125)

Unified Diff: chrome/browser/extensions/chrome_app_sorting.h

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing include Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_app_sorting.h
diff --git a/chrome/browser/extensions/chrome_app_sorting.h b/chrome/browser/extensions/chrome_app_sorting.h
index 2754bc0baaaec978bd273757fbf266e7d40e001f..c29239912c48e3ac68b54745a919565c7fdb5a57 100644
--- a/chrome/browser/extensions/chrome_app_sorting.h
+++ b/chrome/browser/extensions/chrome_app_sorting.h
@@ -27,9 +27,6 @@ class ChromeAppSorting : public AppSorting {
~ChromeAppSorting() override;
// AppSorting implementation:
- void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override;
- void CheckExtensionScopedPrefs() const override;
- void Initialize(const extensions::ExtensionIdList& extension_ids) override;
void FixNTPOrdinalCollisions() override;
void EnsureValidOrdinals(
const std::string& extension_id,
@@ -74,6 +71,7 @@ class ChromeAppSorting : public AppSorting {
// Unit tests.
friend class ChromeAppSortingDefaultOrdinalsBase;
friend class ChromeAppSortingGetMinOrMaxAppLaunchOrdinalsOnPage;
+ friend class ChromeAppSortingInitialize;
friend class ChromeAppSortingInitializeWithNoApps;
friend class ChromeAppSortingPageOrdinalMapping;
friend class ChromeAppSortingSetExtensionVisible;
@@ -152,7 +150,6 @@ class ChromeAppSorting : public AppSorting {
// Returns the number of items in |m| visible on the new tab page.
size_t CountItemsVisibleOnNtp(const AppLaunchOrdinalMap& m) const;
- ExtensionScopedPrefs* extension_scoped_prefs_; // Weak, owns this instance.
content::BrowserContext* browser_context_;
// A map of all the StringOrdinal page ordinals mapping to the collections of
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698