extensions/browser/app_sorting.h - Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_sorting.h

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_system_impl.cc ('K') | « chrome/browser/extensions/test_extension_system.cc ('k') | extensions/browser/app_window/app_window_geometry_cache_unittest.cc » ('j') | extensions/browser/app_window/app_window_geometry_cache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_sorting.h

diff --git a/extensions/browser/app_sorting.h b/extensions/browser/app_sorting.h

index 3ab4c80c51d1f17ebc406ef7c04dea37e53a736f..62c3c4297358d2d744a3a0e2eb90d44e9afba0a9 100644

--- a/extensions/browser/app_sorting.h

+++ b/extensions/browser/app_sorting.h

@@ -21,15 +21,6 @@ class AppSorting {

AppSorting() {}

virtual ~AppSorting() {}

- // Sets the object used to look up preferences. Ownership remains with the

- // caller.

- virtual void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) = 0;

- // CHECKs that SetExtensionScopedPrefs has been called with a non-null object.

- // TODO(mgiuca): Added this to try and diagnose http://crbug.com/476648.

- // Remove it after the investigation is concluded.

- virtual void CheckExtensionScopedPrefs() const = 0;

// Properly initializes internal values that require |extension_ids|.

// SetExtensionScopedPrefs must have been called prior to this.

virtual void Initialize(const extensions::ExtensionIdList& extension_ids) = 0;