Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: extensions/browser/app_window/app_window_geometry_cache_unittest.cc

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests, cleanup Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window_geometry_cache_unittest.cc
diff --git a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
index e1f4068440298217262576b2c982b80a4972d15f..1600693ae181cfb45aa3f51360583df1cb3da0d7 100644
--- a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
+++ b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
@@ -95,9 +95,10 @@ void AppWindowGeometryCacheTest::SetUp() {
pref_service_.get(),
browser_context()->GetPath().AppendASCII("Extensions"),
extension_pref_value_map_.get(),
- scoped_ptr<AppSorting>(new NullAppSorting),
false /* extensions_disabled */,
std::vector<ExtensionPrefsObserver*>()));
+ scoped_ptr<AppSorting> app_sorting(new NullAppSorting);
+ extension_prefs_->set_app_sorting(app_sorting.get());
cache_.reset(
new AppWindowGeometryCache(browser_context(), extension_prefs_.get()));

Powered by Google App Engine
This is Rietveld 408576698