Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/extensions/extension_system_impl.h

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review1 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_IMPL_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_IMPL_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_IMPL_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_IMPL_H_
7 7
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "extensions/browser/extension_system.h" 9 #include "extensions/browser/extension_system.h"
10 #include "extensions/common/one_shot_event.h" 10 #include "extensions/common/one_shot_event.h"
(...skipping 25 matching lines...) Expand all
36 void InitForRegularProfile(bool extensions_enabled) override; 36 void InitForRegularProfile(bool extensions_enabled) override;
37 37
38 ExtensionService* extension_service() override; // shared 38 ExtensionService* extension_service() override; // shared
39 RuntimeData* runtime_data() override; // shared 39 RuntimeData* runtime_data() override; // shared
40 ManagementPolicy* management_policy() override; // shared 40 ManagementPolicy* management_policy() override; // shared
41 SharedUserScriptMaster* shared_user_script_master() override; // shared 41 SharedUserScriptMaster* shared_user_script_master() override; // shared
42 StateStore* state_store() override; // shared 42 StateStore* state_store() override; // shared
43 StateStore* rules_store() override; // shared 43 StateStore* rules_store() override; // shared
44 InfoMap* info_map() override; // shared 44 InfoMap* info_map() override; // shared
45 QuotaService* quota_service() override; // shared 45 QuotaService* quota_service() override; // shared
46 AppSorting* app_sorting() override; // shared
46 47
47 void RegisterExtensionWithRequestContexts( 48 void RegisterExtensionWithRequestContexts(
48 const Extension* extension) override; 49 const Extension* extension) override;
49 50
50 void UnregisterExtensionWithRequestContexts( 51 void UnregisterExtensionWithRequestContexts(
51 const std::string& extension_id, 52 const std::string& extension_id,
52 const UnloadedExtensionInfo::Reason reason) override; 53 const UnloadedExtensionInfo::Reason reason) override;
53 54
54 const OneShotEvent& ready() const override; 55 const OneShotEvent& ready() const override;
55 ContentVerifier* content_verifier() override; // shared 56 ContentVerifier* content_verifier() override; // shared
(...skipping 20 matching lines...) Expand all
76 void Shutdown() override; 77 void Shutdown() override;
77 78
78 StateStore* state_store(); 79 StateStore* state_store();
79 StateStore* rules_store(); 80 StateStore* rules_store();
80 ExtensionService* extension_service(); 81 ExtensionService* extension_service();
81 RuntimeData* runtime_data(); 82 RuntimeData* runtime_data();
82 ManagementPolicy* management_policy(); 83 ManagementPolicy* management_policy();
83 SharedUserScriptMaster* shared_user_script_master(); 84 SharedUserScriptMaster* shared_user_script_master();
84 InfoMap* info_map(); 85 InfoMap* info_map();
85 QuotaService* quota_service(); 86 QuotaService* quota_service();
87 AppSorting* app_sorting();
86 const OneShotEvent& ready() const { return ready_; } 88 const OneShotEvent& ready() const { return ready_; }
87 ContentVerifier* content_verifier(); 89 ContentVerifier* content_verifier();
88 90
89 private: 91 private:
90 Profile* profile_; 92 Profile* profile_;
91 93
92 // The services that are shared between normal and incognito profiles. 94 // The services that are shared between normal and incognito profiles.
93 95
94 scoped_ptr<StateStore> state_store_; 96 scoped_ptr<StateStore> state_store_;
95 scoped_ptr<StateStoreNotificationObserver> 97 scoped_ptr<StateStoreNotificationObserver>
96 state_store_notification_observer_; 98 state_store_notification_observer_;
97 scoped_ptr<StateStore> rules_store_; 99 scoped_ptr<StateStore> rules_store_;
98 scoped_ptr<NavigationObserver> navigation_observer_; 100 scoped_ptr<NavigationObserver> navigation_observer_;
99 // Shared memory region manager for scripts statically declared in extension 101 // Shared memory region manager for scripts statically declared in extension
100 // manifests. This region is shared between all extensions. 102 // manifests. This region is shared between all extensions.
101 scoped_ptr<SharedUserScriptMaster> shared_user_script_master_; 103 scoped_ptr<SharedUserScriptMaster> shared_user_script_master_;
102 scoped_ptr<RuntimeData> runtime_data_; 104 scoped_ptr<RuntimeData> runtime_data_;
103 // ExtensionService depends on StateStore, Blacklist and RuntimeData. 105 // ExtensionService depends on StateStore, Blacklist and RuntimeData.
104 scoped_ptr<ExtensionService> extension_service_; 106 scoped_ptr<ExtensionService> extension_service_;
105 scoped_ptr<ManagementPolicy> management_policy_; 107 scoped_ptr<ManagementPolicy> management_policy_;
106 // extension_info_map_ needs to outlive process_manager_. 108 // extension_info_map_ needs to outlive process_manager_.
107 scoped_refptr<InfoMap> extension_info_map_; 109 scoped_refptr<InfoMap> extension_info_map_;
108 scoped_ptr<QuotaService> quota_service_; 110 scoped_ptr<QuotaService> quota_service_;
111 scoped_ptr<AppSorting> app_sorting_;
109 112
110 // For verifying the contents of extensions read from disk. 113 // For verifying the contents of extensions read from disk.
111 scoped_refptr<ContentVerifier> content_verifier_; 114 scoped_refptr<ContentVerifier> content_verifier_;
112 115
113 #if defined(OS_CHROMEOS) 116 #if defined(OS_CHROMEOS)
114 scoped_ptr<chromeos::DeviceLocalAccountManagementPolicyProvider> 117 scoped_ptr<chromeos::DeviceLocalAccountManagementPolicyProvider>
115 device_local_account_management_policy_provider_; 118 device_local_account_management_policy_provider_;
116 #endif 119 #endif
117 120
118 OneShotEvent ready_; 121 OneShotEvent ready_;
119 }; 122 };
120 123
121 Profile* profile_; 124 Profile* profile_;
122 125
123 Shared* shared_; 126 Shared* shared_;
124 127
125 DISALLOW_COPY_AND_ASSIGN(ExtensionSystemImpl); 128 DISALLOW_COPY_AND_ASSIGN(ExtensionSystemImpl);
126 }; 129 };
127 130
128 } // namespace extensions 131 } // namespace extensions
129 132
130 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_IMPL_H_ 133 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698