Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: extensions/shell/browser/shell_extensions_browser_client.cc

Issue 1254363004: Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix extensions_unittests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/shell_extensions_browser_client.h" 5 #include "extensions/shell/browser/shell_extensions_browser_client.h"
6 6
7 #include "content/public/browser/browser_context.h" 7 #include "content/public/browser/browser_context.h"
8 #include "content/public/browser/browser_thread.h" 8 #include "content/public/browser/browser_thread.h"
9 #include "content/public/browser/render_frame_host.h" 9 #include "content/public/browser/render_frame_host.h"
10 #include "extensions/browser/api/extensions_api_client.h" 10 #include "extensions/browser/api/extensions_api_client.h"
11 #include "extensions/browser/api/generated_api_registration.h" 11 #include "extensions/browser/api/generated_api_registration.h"
12 #include "extensions/browser/app_sorting.h" 12 #include "extensions/browser/app_sorting.h"
not at google - send to devlin 2015/08/03 21:12:08 You can remove this #include.
Marc Treib 2015/08/04 08:36:29 Done.
13 #include "extensions/browser/event_router.h" 13 #include "extensions/browser/event_router.h"
14 #include "extensions/browser/extension_function_registry.h" 14 #include "extensions/browser/extension_function_registry.h"
15 #include "extensions/browser/mojo/service_registration.h" 15 #include "extensions/browser/mojo/service_registration.h"
16 #include "extensions/browser/null_app_sorting.h" 16 #include "extensions/browser/null_app_sorting.h"
17 #include "extensions/browser/updater/null_extension_cache.h" 17 #include "extensions/browser/updater/null_extension_cache.h"
18 #include "extensions/browser/url_request_util.h" 18 #include "extensions/browser/url_request_util.h"
19 #include "extensions/shell/browser/api/generated_api_registration.h" 19 #include "extensions/shell/browser/api/generated_api_registration.h"
20 #include "extensions/shell/browser/shell_extension_host_delegate.h" 20 #include "extensions/shell/browser/shell_extension_host_delegate.h"
21 #include "extensions/shell/browser/shell_extension_system_factory.h" 21 #include "extensions/shell/browser/shell_extension_system_factory.h"
22 #include "extensions/shell/browser/shell_extension_web_contents_observer.h" 22 #include "extensions/shell/browser/shell_extension_web_contents_observer.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 } 149 }
150 150
151 bool ShellExtensionsBrowserClient::DidVersionUpdate(BrowserContext* context) { 151 bool ShellExtensionsBrowserClient::DidVersionUpdate(BrowserContext* context) {
152 // TODO(jamescook): We might want to tell extensions when app_shell updates. 152 // TODO(jamescook): We might want to tell extensions when app_shell updates.
153 return false; 153 return false;
154 } 154 }
155 155
156 void ShellExtensionsBrowserClient::PermitExternalProtocolHandler() { 156 void ShellExtensionsBrowserClient::PermitExternalProtocolHandler() {
157 } 157 }
158 158
159 scoped_ptr<AppSorting> ShellExtensionsBrowserClient::CreateAppSorting(
160 content::BrowserContext* context) {
161 return scoped_ptr<AppSorting>(new NullAppSorting);
162 }
163
164 bool ShellExtensionsBrowserClient::IsRunningInForcedAppMode() { 159 bool ShellExtensionsBrowserClient::IsRunningInForcedAppMode() {
165 return false; 160 return false;
166 } 161 }
167 162
168 ApiActivityMonitor* ShellExtensionsBrowserClient::GetApiActivityMonitor( 163 ApiActivityMonitor* ShellExtensionsBrowserClient::GetApiActivityMonitor(
169 BrowserContext* context) { 164 BrowserContext* context) {
170 // app_shell doesn't monitor API function calls or events. 165 // app_shell doesn't monitor API function calls or events.
171 return NULL; 166 return NULL;
172 } 167 }
173 168
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 api_client_.reset(api_client); 236 api_client_.reset(api_client);
242 } 237 }
243 238
244 ExtensionWebContentsObserver* 239 ExtensionWebContentsObserver*
245 ShellExtensionsBrowserClient::GetExtensionWebContentsObserver( 240 ShellExtensionsBrowserClient::GetExtensionWebContentsObserver(
246 content::WebContents* web_contents) { 241 content::WebContents* web_contents) {
247 return ShellExtensionWebContentsObserver::FromWebContents(web_contents); 242 return ShellExtensionWebContentsObserver::FromWebContents(web_contents);
248 } 243 }
249 244
250 } // namespace extensions 245 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698