Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem

chrome/browser/extensions/test_extension_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/test_extension_prefs.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/json_pref_store.h"
 #include "base/prefs/pref_value_store.h"
 #include "base/run_loop.h"
 #include "base/sequenced_task_runner.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/values.h"
+#include "chrome/browser/extensions/chrome_app_sorting.h"
+#include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/prefs/pref_service_mock_factory.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/common/chrome_constants.h"
 #include "components/crx_file/id_util.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/extension_pref_store.h"
 #include "extensions/browser/extension_pref_value_map.h"
 #include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/extension_prefs_factory.h"
+#include "extensions/browser/extension_system.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_constants.h"
 #include "sync/api/string_ordinal.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 namespace extensions {
 
@@ skipping 29 matching lines @@
   extensions_dir_ = temp_dir_.path().AppendASCII("Extensions");
   EXPECT_TRUE(base::CreateDirectory(extensions_dir_));
 
   ResetPrefRegistry();
   RecreateExtensionPrefs();
 }
 
 TestExtensionPrefs::~TestExtensionPrefs() {
 }
 
+ExtensionPrefs* TestExtensionPrefs::prefs() {
+  return ExtensionPrefs::Get(&profile_);
+}
+
+const ExtensionPrefs& TestExtensionPrefs::const_prefs() const {

[not at google - send to devlin, 2015/08/03 21:12:08]

Is there even any point in this const version? When I grep for "const
TestExtensionPrefs" nothing shows up.

[Marc Treib, 2015/08/04 08:36:28]

I hadn't checked. You're right, it's not used anywhere. Removed it.

+  return *ExtensionPrefs::Get(const_cast<TestingProfile*>(&profile_));
+}
+
 PrefService* TestExtensionPrefs::pref_service() {
   return pref_service_.get();
 }
 
 const scoped_refptr<user_prefs::PrefRegistrySyncable>&
 TestExtensionPrefs::pref_registry() {
   return pref_registry_;
 }
 
 void TestExtensionPrefs::ResetPrefRegistry() {
@@ skipping 17 matching lines @@
             run_loop.QuitClosure()));
     run_loop.Run();
   }
 
   extension_pref_value_map_.reset(new ExtensionPrefValueMap);
   PrefServiceMockFactory factory;
   factory.SetUserPrefsFile(preferences_file_, task_runner_.get());
   factory.set_extension_prefs(
       new ExtensionPrefStore(extension_pref_value_map_.get(), false));
   pref_service_ = factory.CreateSyncable(pref_registry_.get()).Pass();
-
-  prefs_.reset(ExtensionPrefs::Create(
+  scoped_ptr<ExtensionPrefs> prefs(ExtensionPrefs::Create(
+      &profile_,
       pref_service_.get(),
       temp_dir_.path(),
       extension_pref_value_map_.get(),
-      ExtensionsBrowserClient::Get()->CreateAppSorting(nullptr).Pass(),
       extensions_disabled_,
       std::vector<ExtensionPrefsObserver*>(),
       // Guarantee that no two extensions get the same installation time
       // stamp and we can reliably assert the installation order in the tests.
       scoped_ptr<ExtensionPrefs::TimeProvider>(new IncrementalTimeProvider())));
+  ExtensionPrefsFactory::GetInstance()->SetInstanceForTesting(&profile_,
+                                                              prefs.Pass());
+  // Hack: After recreating ExtensionPrefs, the AppSorting also needs to be
+  // recreated. (ExtensionPrefs is never recreated in non-test code.)
+  static_cast<TestExtensionSystem*>(ExtensionSystem::Get(&profile_))
+      ->RecreateAppSorting();
 }
 
 scoped_refptr<Extension> TestExtensionPrefs::AddExtension(
     const std::string& name) {
   base::DictionaryValue dictionary;
   dictionary.SetString(manifest_keys::kName, name);
   dictionary.SetString(manifest_keys::kVersion, "0.1");
   return AddExtensionWithManifest(dictionary, Manifest::INTERNAL);
 }
 
@@ skipping 21 matching lines @@
   EXPECT_TRUE(manifest.GetString(manifest_keys::kName, &name));
   base::FilePath path =  extensions_dir_.AppendASCII(name);
   std::string errors;
   scoped_refptr<Extension> extension = Extension::Create(
       path, location, manifest, extra_flags, &errors);
   EXPECT_TRUE(extension.get()) << errors;
   if (!extension.get())
     return NULL;
 
   EXPECT_TRUE(crx_file::id_util::IdIsValid(extension->id()));
-  prefs_->OnExtensionInstalled(extension.get(),
-                               Extension::ENABLED,
-                               syncer::StringOrdinal::CreateInitialOrdinal(),
-                               std::string());
+  prefs()->OnExtensionInstalled(extension.get(),
+                                Extension::ENABLED,
+                                syncer::StringOrdinal::CreateInitialOrdinal(),
+                                std::string());
   return extension;
 }
 
 std::string TestExtensionPrefs::AddExtensionAndReturnId(
     const std::string& name) {
   scoped_refptr<Extension> extension(AddExtension(name));
   return extension->id();
 }
 
 void TestExtensionPrefs::AddExtension(Extension* extension) {
-  prefs_->OnExtensionInstalled(extension,
-                               Extension::ENABLED,
-                               syncer::StringOrdinal::CreateInitialOrdinal(),
-                               std::string());
+  prefs()->OnExtensionInstalled(extension,
+                                Extension::ENABLED,
+                                syncer::StringOrdinal::CreateInitialOrdinal(),
+                                std::string());
 }
 
 PrefService* TestExtensionPrefs::CreateIncognitoPrefService() const {
   return pref_service_->CreateIncognitoPrefService(
       new ExtensionPrefStore(extension_pref_value_map_.get(), true));
 }
 
 void TestExtensionPrefs::set_extensions_disabled(bool extensions_disabled) {
   extensions_disabled_ = extensions_disabled;
 }
 
+ChromeAppSorting* TestExtensionPrefs::app_sorting() {
+  return static_cast<ChromeAppSorting*>(
+      ExtensionSystem::Get(&profile_)->app_sorting());
+}
+
 }  // namespace extensions