Move ownership of AppSorting from ExtensionPrefs to ExtensionSystem

chrome/browser/extensions/test_extension_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/test_extension_system.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/chrome_app_sorting.h"
 #include "chrome/browser/extensions/extension_management.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/shared_module_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/browser_thread.h"
-#include "extensions/browser/extension_pref_value_map.h"
-#include "extensions/browser/extension_pref_value_map_factory.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/quota_service.h"
 #include "extensions/browser/runtime_data.h"
 #include "extensions/browser/state_store.h"
 #include "extensions/browser/value_store/testing_value_store.h"
 
 using content::BrowserThread;
 
 namespace extensions {
 
 TestExtensionSystem::TestExtensionSystem(Profile* profile)
     : profile_(profile),
       value_store_(NULL),
       info_map_(new InfoMap()),
-      quota_service_(new QuotaService()) {}
+      quota_service_(new QuotaService()),
+      app_sorting_(new ChromeAppSorting(profile_)) {

[Marc Treib, 2015/08/03 15:28:03]

Turns out a bunch of tests depend on this returning an actual ChromeAppSorting
rather than a NullAppSorting.

+  ExtensionPrefs::Get(profile_)->set_app_sorting(app_sorting_.get());
+}
 
 TestExtensionSystem::~TestExtensionSystem() {
 }
 
 void TestExtensionSystem::Shutdown() {
   if (extension_service_)
     extension_service_->Shutdown();
 }
 
-scoped_ptr<ExtensionPrefs> TestExtensionSystem::CreateExtensionPrefs(
-    const base::CommandLine* command_line,
-    const base::FilePath& install_directory) {
-  bool extensions_disabled =
-      command_line && command_line->HasSwitch(switches::kDisableExtensions);
-
-  // Note that the GetPrefs() creates a TestingPrefService, therefore
-  // the extension controlled pref values set in ExtensionPrefs
-  // are not reflected in the pref service. One would need to
-  // inject a new ExtensionPrefStore(extension_pref_value_map, false).
-
-  return make_scoped_ptr(ExtensionPrefs::Create(
-      profile_->GetPrefs(), install_directory,
-      ExtensionPrefValueMapFactory::GetForBrowserContext(profile_),
-      ExtensionsBrowserClient::Get()->CreateAppSorting(profile_).Pass(),
-      extensions_disabled, std::vector<ExtensionPrefsObserver*>()));
-}
-
 ExtensionService* TestExtensionSystem::CreateExtensionService(
     const base::CommandLine* command_line,
     const base::FilePath& install_directory,
     bool autoupdate_enabled) {
   // The ownership of |value_store_| is immediately transferred to state_store_,
   // but we keep a naked pointer to the TestingValueStore.
   scoped_ptr<TestingValueStore> value_store(new TestingValueStore());
   value_store_ = value_store.get();
   state_store_.reset(new StateStore(profile_, value_store.Pass()));
   management_policy_.reset(new ManagementPolicy());
@@ skipping 40 matching lines @@
 StateStore* TestExtensionSystem::rules_store() {
   return state_store_.get();
 }
 
 InfoMap* TestExtensionSystem::info_map() { return info_map_.get(); }
 
 QuotaService* TestExtensionSystem::quota_service() {
   return quota_service_.get();
 }
 
+AppSorting* TestExtensionSystem::app_sorting() {
+  return app_sorting_.get();
+}
+
 const OneShotEvent& TestExtensionSystem::ready() const {
   return ready_;
 }
 
 ContentVerifier* TestExtensionSystem::content_verifier() {
   return NULL;
 }
 
 scoped_ptr<ExtensionSet> TestExtensionSystem::GetDependentExtensions(
     const Extension* extension) {
   return extension_service()->shared_module_service()->GetDependentExtensions(
       extension);
 }
 
 // static
 scoped_ptr<KeyedService> TestExtensionSystem::Build(
     content::BrowserContext* profile) {
   return make_scoped_ptr(
       new TestExtensionSystem(static_cast<Profile*>(profile)));
 }
 
 }  // namespace extensions