Move creation of the various WebDatabaseTable types out of WebDatabase.

chrome/browser/webdata/web_database_service_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/web_database_service_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "chrome/browser/api/webdata/web_data_results.h"
 #include "chrome/browser/api/webdata/web_data_service_consumer.h"
 // TODO(caitkp): Remove this autofill dependency.
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/webdata/autofill_table.h"
+#include "chrome/browser/webdata/keyword_table.h"
+#include "chrome/browser/webdata/logins_table.h"
+#include "chrome/browser/webdata/token_service_table.h"
+#include "chrome/browser/webdata/web_apps_table.h"
 #include "chrome/browser/webdata/web_data_request_manager.h"
 #include "chrome/browser/webdata/web_data_service.h"
+#include "chrome/browser/webdata/web_intents_table.h"
 #include "components/autofill/browser/autofill_country.h"
 
 using base::Bind;
 using base::FilePath;
 using content::BrowserThread;
 
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // WebDatabaseServiceInternal implementation.
@@ skipping 43 matching lines @@
   friend class base::DeleteHelper<WebDatabaseServiceInternal>;
 
   virtual ~WebDatabaseServiceInternal();
 
   // Commit the current transaction.
   void Commit();
 
   // Path to database file.
   FilePath db_path_;
 
+  scoped_ptr<AutofillTable> autofill_table_;
+  scoped_ptr<KeywordTable> keyword_table_;
+  scoped_ptr<LoginsTable> logins_table_;
+  scoped_ptr<TokenServiceTable> token_service_table_;
+  scoped_ptr<WebAppsTable> web_apps_table_;
+  scoped_ptr<WebIntentsTable> web_intents_table_;
+
   scoped_ptr<WebDatabase> db_;
 
   // Keeps track of all pending requests made to the db.
   scoped_refptr<WebDataRequestManager> request_manager_;
 
   // State of database initialization. Used to prevent the executing of tasks
   // before the db is ready.
   sql::InitStatus init_status_;
 
   // True if an attempt has been made to load the database (even if the attempt
@@ skipping 29 matching lines @@
     callback.Run(LoadDatabaseIfNecessary());
   }
 }
 
 sql::InitStatus WebDatabaseServiceInternal::LoadDatabaseIfNecessary() {
   if (init_complete_ || db_path_.empty()) {
     return init_status_;
   }
   init_complete_ = true;
   db_.reset(new WebDatabase());
+
+  // All tables objects that participate in managing the database must
+  // be added here.
+  autofill_table_.reset(new AutofillTable());
+  db_->AddTable(autofill_table_.get());
+
+  keyword_table_.reset(new KeywordTable());
+  db_->AddTable(keyword_table_.get());
+
+  // TODO(mdm): We only really need the LoginsTable on Windows for IE7 password
+  // access, but for now, we still create it on all platforms since it deletes
+  // the old logins table. We can remove this after a while, e.g. in M22 or so.
+  logins_table_.reset(new LoginsTable());
+  db_->AddTable(logins_table_.get());
+
+  token_service_table_.reset(new TokenServiceTable());
+  db_->AddTable(token_service_table_.get());
+
+  web_apps_table_.reset(new WebAppsTable());
+  db_->AddTable(web_apps_table_.get());
+
+  // TODO(thakis): Add a migration to delete the SQL table used by
+  // WebIntentsTable, then remove this.
+  web_intents_table_.reset(new WebIntentsTable());
+  db_->AddTable(web_intents_table_.get());
+
   init_status_ = db_->Init(db_path_, app_locale_);
   if (init_status_ != sql::INIT_OK) {
     LOG(ERROR) << "Cannot initialize the web database: " << init_status_;
     db_.reset(NULL);
     return init_status_;
   }
 
   db_->BeginTransaction();
   return init_status_;
 }
@@ skipping 123 matching lines @@
 void WebDatabaseServiceImpl::CancelRequest(WebDataServiceBase::Handle h) {
   if (wdbs_internal_)
     wdbs_internal_->request_manager()->CancelRequest(h);
 }
 
 // Testing
 void WebDatabaseServiceImpl::set_init_complete(bool complete) {
   if (wdbs_internal_)
     wdbs_internal_->set_init_complete(complete);
 }