Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: Source/WebCore/Modules/webaudio/AudioNodeOutput.cpp

Issue 12543030: Merge 144417 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/Modules/webaudio/AudioNodeInput.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/Modules/webaudio/AudioNodeOutput.cpp
===================================================================
--- Source/WebCore/Modules/webaudio/AudioNodeOutput.cpp (revision 145455)
+++ Source/WebCore/Modules/webaudio/AudioNodeOutput.cpp (working copy)
@@ -132,6 +132,8 @@
AudioBus* AudioNodeOutput::bus() const
{
+ // FIXME: Add ASSERTs/checkings to restrict the calling of bus(), because the calling is
+ // only safe after setting the in-place bus in pull() and before updating the referred bus.
ASSERT(const_cast<AudioNodeOutput*>(this)->context()->isAudioThread());
ASSERT(m_actualDestinationBus);
return m_actualDestinationBus;
« no previous file with comments | « Source/WebCore/Modules/webaudio/AudioNodeInput.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698