Make graph output optional in bench_graphs_svg

bench/bench_graph_svg.py

 '''
 Created on May 16, 2011
 
 @author: bungeman
 '''
 import bench_util
 import getopt
 import httplib
 import itertools
 import json
@@ skipping 36 matching lines @@
     print '   Will raise exception if actual bench values are out of range.'
     print '   See bench_expectations.txt for data format and examples.'
     print '-f <revision>[:<revision>] the revisions to use for fitting.'
     print '   Negative <revision> is taken as offset from most recent revision.'
     print '-i <time> the time to ignore (w, c, g, etc).'
     print '   The flag is ignored when -t is set; otherwise we plot all the'
     print '   times except the one specified here.'
     print '-l <title> title to use for the output graph'
     print '-m <representation> representation of bench value.'
     print '   See _ListAlgorithm class in bench_util.py.'
-    print '-o <path> path to which to write output; writes to stdout if not specified'
+    print '-o <path> path to which to write output.'
     print '-r <revision>[:<revision>] the revisions to show.'
     print '   Negative <revision> is taken as offset from most recent revision.'
     print '-s <setting>[=<value>] a setting to show (alpha, scalar, etc).'
     print '-t <time> the time to show (w, c, g, etc).'
     print '-x <int> the desired width of the svg.'
     print '-y <int> the desired height of the svg.'
     print '--default-setting <setting>[=<value>] setting for those without.'
     
 
 class Label:
@@ skipping 257 matching lines @@
     except getopt.GetoptError, err:
         print str(err) 
         usage()
         sys.exit(2)
     
     directory = None
     config_of_interest = None
     bench_of_interest = None
     time_of_interest = None
     time_to_ignore = None
+    output_path = None
     bench_expectations = {}
     appengine_url = None  # used for adding data to appengine datastore
     rep = None  # bench representation algorithm
     revision_range = '0:'
     regression_range = '0:'
     latest_revision = None
     requested_height = None
     requested_width = None
     title = 'Bench graph'
     settings = {}
@@ skipping 110 matching lines @@
                 read_expectations(bench_expectations, value)
             elif option == "-f":
                 regression_range = value
             elif option == "-i":
                 time_to_ignore = value
             elif option == "-l":
                 title = value
             elif option == "-m":
                 rep = value
             elif option == "-o":
-                redirect_stdout(value)
+                output_path = value
+                redirect_stdout(output_path)
             elif option == "-r":
                 revision_range = value
             elif option == "-s":
                 add_setting(settings, value)
             elif option == "-t":
                 time_of_interest = value
             elif option == "-x":
                 requested_width = int(value)
             elif option == "-y":
                 requested_height = int(value)
             elif option == "--default-setting":
                 add_setting(default_settings, value)
             else:
                 usage()
                 assert False, "unhandled option"
     except ValueError:
         usage()
         sys.exit(2)
 
     if directory is None:
         usage()
         sys.exit(2)
 
+    if not output_path:
+        print 'Warning: No output path provided. No graphs will be written.'
+
     if time_of_interest:
         time_to_ignore = None
 
     # The title flag (-l) provided in buildbot slave is in the format
     # Bench_Performance_for_Skia_<platform>, and we want to extract <platform>
     # for use in platform_and_alg to track matching benches later. If title flag
     # is not in this format, there may be no matching benches in the file
     # provided by the expectation_file flag (-e).
     bot = title  # To store the platform as bot name
     platform_and_alg = title
@@ skipping 26 matching lines @@
                    , settings
                    , bench_of_interest
                    , config_of_interest
                    , time_of_interest
                    , time_to_ignore)
 
     regressions = create_regressions(lines
                                    , oldest_regression
                                    , newest_regression)
 
-    output_xhtml(lines, oldest_revision, newest_revision, ignored_revision_data_points,
-                 regressions, requested_width, requested_height, title)
+    if output_path:
+        output_xhtml(lines, oldest_revision, newest_revision,
+                     ignored_revision_data_points, regressions, requested_width,
+                     requested_height, title)
 
     if appengine_url:
         write_to_appengine(lines, appengine_url, newest_revision, bot)
 
-    check_expectations(lines, bench_expectations, newest_revision,
-                       platform_and_alg)
+    if bench_expectations:
+        check_expectations(lines, bench_expectations, newest_revision,
+                           platform_and_alg)
 
 def qa(out):
     """Stringify input and quote as an xml attribute."""
     return xml.sax.saxutils.quoteattr(str(out))
 def qe(out):
     """Stringify input and escape as xml data."""
     return xml.sax.saxutils.escape(str(out))
 
 def create_select(qualifier, lines, select_id=None):
     """Output select with options showing lines which qualifier maps to it.
@@ skipping 479 matching lines @@
     print '<a id="rev_link" xlink:href="" target="_top">'
     print '<text id="revision" x="0" y=%s style="' % qa(font_size*2)
     print 'font-size: %s; ' % qe(font_size)
     print 'stroke: #0000dd; text-decoration: underline; '
     print '"> </text></a>'
 
     print '</svg>'
 
 if __name__ == "__main__":
     main()