Establish components/autofill and move some files

Establish components/autofill and move some files

Moving autofill related only files under chrome/common/ to components/autofill/common
We are going to move autofill to components/autofill to componentize it. This is the first moving CL.


BUG=140037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186632

[Jói, 2013-03-06 22:02:35]

I think we may also want to move chrome/renderer/page_click_listener.h|cc,
chrome/renderer/page_click_tracker.h|cc, they seem to only be used by Autofill
(and initialized in chrome_content_renderer_client.cc).

We could do this in the change that moves all of the remaining renderer and
browser code though.  page_click_tracker.cc has at least one dependency that we
won't move so would be good to break that first.

[kaiwang, 2013-03-07 00:01:04]

OWNERs, please review this:

joi: components/
isherman: chrome/browser/autofill/ and chrome/renderer/autofill
sky: everything else under chrome/

Thanks a lot!

[Jói, 2013-03-07 00:13:00]

LGTM with a nit.  I reviewed the whole change.

Cheers,
Jói

https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi#n...
components/autofill.gypi:1: # Copyright (c) 2012 The Chromium Authors. All
rights reserved.
2013

[Ilya Sherman, 2013-03-07 00:21:36]

LGTM2

[sky, 2013-03-07 01:20:45]

LGTM

[kaiwang, 2013-03-07 01:26:56]

https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi#n...
components/autofill.gypi:1: # Copyright (c) 2012 The Chromium Authors. All
rights reserved.
On 2013/03/07 00:13:00, Jói wrote:
> 2013

Done.

[commit-bot: I haz the power, 2013-03-07 01:39:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12543010/14002

[commit-bot: I haz the power, 2013-03-07 01:40:11]

Failed to apply patch for
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
  Hunk #1 FAILED at 35.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc.rej

Patch:       chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index
ef4c24102f60e6b630f896a33a6f71030254f6ed..96fdad60ce3277dc6ec8af2c62adf35cfcbc893b
100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -35,8 +35,8 @@
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/extensions/native_app_window.h"
 #include "chrome/browser/ui/extensions/shell_window.h"
-#include "chrome/common/form_data.h"
 #include "chrome/common/pref_names.h"
+#include "components/autofill/common/form_data.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"

[commit-bot: I haz the power, 2013-03-07 02:09:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12543010/19001

[commit-bot: I haz the power, 2013-03-07 05:44:46]

Change committed as 186632