Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1819)

Unified Diff: pkg/analyzer-experimental/lib/src/generated/ast.dart

Issue 12543003: Use limited JavaStringBuilder implementation instead of Dart StringBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweak JavaStringBuilder. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer-experimental/lib/src/generated/ast.dart
diff --git a/pkg/analyzer-experimental/lib/src/generated/ast.dart b/pkg/analyzer-experimental/lib/src/generated/ast.dart
index a7278e78a66b9679dec812d0a4c90ffd7aa26d38..0b9e6a2206844ed15c884fbe8ac0bb73d0da6237 100644
--- a/pkg/analyzer-experimental/lib/src/generated/ast.dart
+++ b/pkg/analyzer-experimental/lib/src/generated/ast.dart
@@ -6798,15 +6798,15 @@ class LibraryIdentifier extends Identifier {
Element get element => null;
Token get endToken => _components.endToken;
String get name {
- StringBuffer builder = new StringBuffer();
+ JavaStringBuilder builder = new JavaStringBuilder();
bool needsPeriod = false;
for (SimpleIdentifier identifier in _components) {
if (needsPeriod) {
- builder.write(".");
+ builder.append(".");
} else {
needsPeriod = true;
}
- builder.write(identifier.name);
+ builder.append(identifier.name);
}
return builder.toString();
}
@@ -10849,13 +10849,13 @@ class ConstantEvaluator extends GeneralizingASTVisitor<Object> {
*/
static Object NOT_A_CONSTANT = new Object();
Object visitAdjacentStrings(AdjacentStrings node) {
- StringBuffer builder = new StringBuffer();
+ JavaStringBuilder builder = new JavaStringBuilder();
for (StringLiteral string in node.strings) {
Object value = string.accept(this);
if (identical(value, NOT_A_CONSTANT)) {
return value;
}
- builder.write(value);
+ builder.append(value);
}
return builder.toString();
}
@@ -11054,13 +11054,13 @@ class ConstantEvaluator extends GeneralizingASTVisitor<Object> {
Object visitSimpleIdentifier(SimpleIdentifier node) => getConstantValue(null);
Object visitSimpleStringLiteral(SimpleStringLiteral node) => node.value;
Object visitStringInterpolation(StringInterpolation node) {
- StringBuffer builder = new StringBuffer();
+ JavaStringBuilder builder = new JavaStringBuilder();
for (InterpolationElement element in node.elements) {
Object value = element.accept(this);
if (identical(value, NOT_A_CONSTANT)) {
return value;
}
- builder.write(value);
+ builder.append(value);
}
return builder.toString();
}

Powered by Google App Engine
This is Rietveld 408576698