Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1254293008: Perform initial GC to improve inspector/search test stability. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 3 months ago
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Perform initial GC to improve inspector/search test stability. With Oilpan, inspector tests enumerating resources are susceptible to "GC lag", including resources that have yet to be GCed and swept out. To ensure a stable baseline for the tests, perform an initial, flushing GC. R=haraken BUG=513393 Committed: https://crrev.com/1bedea1cfe11f4c8c2a6b7ea2a60794d943c853c git-svn-id: svn://svn.chromium.org/blink/trunk@199665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M LayoutTests/http/tests/inspector/search/search-test.js View 1 chunk +5 lines, -1 line 2 comments Download

Messages

Total messages: 10 (3 generated)
sof
please take a look.
5 years, 4 months ago (2015-07-29 13:41:39 UTC) #2
haraken
LGTM https://codereview.chromium.org/1254293008/diff/1/LayoutTests/http/tests/inspector/search/search-test.js File LayoutTests/http/tests/inspector/search/search-test.js (right): https://codereview.chromium.org/1254293008/diff/1/LayoutTests/http/tests/inspector/search/search-test.js#newcode4 LayoutTests/http/tests/inspector/search/search-test.js:4: GCController.collect(); Shall we use GCController.collectAll()?
5 years, 4 months ago (2015-07-29 13:43:23 UTC) #4
sof
https://codereview.chromium.org/1254293008/diff/1/LayoutTests/http/tests/inspector/search/search-test.js File LayoutTests/http/tests/inspector/search/search-test.js (right): https://codereview.chromium.org/1254293008/diff/1/LayoutTests/http/tests/inspector/search/search-test.js#newcode4 LayoutTests/http/tests/inspector/search/search-test.js:4: GCController.collect(); On 2015/07/29 13:43:23, haraken wrote: > > Shall ...
5 years, 4 months ago (2015-07-29 13:43:57 UTC) #5
haraken
On 2015/07/29 13:43:57, sof wrote: > https://codereview.chromium.org/1254293008/diff/1/LayoutTests/http/tests/inspector/search/search-test.js > File LayoutTests/http/tests/inspector/search/search-test.js (right): > > https://codereview.chromium.org/1254293008/diff/1/LayoutTests/http/tests/inspector/search/search-test.js#newcode4 > ...
5 years, 4 months ago (2015-07-29 13:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254293008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254293008/1
5 years, 4 months ago (2015-07-29 14:44:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199665
5 years, 4 months ago (2015-07-29 14:47:59 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:53:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bedea1cfe11f4c8c2a6b7ea2a60794d943c853c

Powered by Google App Engine
This is Rietveld 408576698