Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: media/base/android/media_codec_decoder_unittest.cc

Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-browserseek
Patch Set: Rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_codec_decoder.cc ('k') | media/base/android/media_codec_player.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_codec_decoder_unittest.cc
diff --git a/media/base/android/media_codec_decoder_unittest.cc b/media/base/android/media_codec_decoder_unittest.cc
index ceef6be829a2646a5d3e27ec97940d3b0168e94d..a3ac8637654eaaf1d737be53ed7f65fde5cc52f2 100644
--- a/media/base/android/media_codec_decoder_unittest.cc
+++ b/media/base/android/media_codec_decoder_unittest.cc
@@ -493,7 +493,10 @@ TEST_F(MediaCodecDecoderTest, AudioPlayTillCompletion) {
EXPECT_TRUE(decoder_->IsCompleted());
// Last buffered timestamp should be no less than PTS.
- EXPECT_EQ(22, pts_stat_.num_values());
+ // The number of hits in pts_stat_ depends on the preroll implementation.
+ // We might not report the time for the first buffer after preroll that
+ // is written to the audio track. pts_stat_.num_values() is either 21 or 22.
+ EXPECT_LE(21, pts_stat_.num_values());
EXPECT_LE(data_factory_->last_pts(), pts_stat_.max());
DVLOG(0) << "AudioPlayTillCompletion stopping";
« no previous file with comments | « media/base/android/media_codec_decoder.cc ('k') | media/base/android/media_codec_player.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698