Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: media/base/android/media_codec_audio_decoder.cc

Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-browserseek
Patch Set: Rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_codec_audio_decoder.h ('k') | media/base/android/media_codec_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_codec_audio_decoder.cc
diff --git a/media/base/android/media_codec_audio_decoder.cc b/media/base/android/media_codec_audio_decoder.cc
index f2fae725edd07916f206e78b110ea90e033935b2..f6012e15b0792bf33ed004e1c7196e9aba261f29 100644
--- a/media/base/android/media_codec_audio_decoder.cc
+++ b/media/base/android/media_codec_audio_decoder.cc
@@ -40,6 +40,7 @@ MediaCodecAudioDecoder::MediaCodecAudioDecoder(
}
MediaCodecAudioDecoder::~MediaCodecAudioDecoder() {
+ DCHECK(media_task_runner_->BelongsToCurrentThread());
DVLOG(1) << "AudioDecoder::~AudioDecoder()";
ReleaseDecoderResources();
}
@@ -64,6 +65,15 @@ void MediaCodecAudioDecoder::SetDemuxerConfigs(const DemuxerConfigs& configs) {
output_sampling_rate_ = configs.audio_sampling_rate;
}
+void MediaCodecAudioDecoder::ReleaseDecoderResources() {
+ DCHECK(media_task_runner_->BelongsToCurrentThread());
+ DVLOG(1) << class_name() << "::" << __FUNCTION__;
+
+ DoEmergencyStop();
+
+ ReleaseMediaCodec();
+}
+
void MediaCodecAudioDecoder::Flush() {
DCHECK(media_task_runner_->BelongsToCurrentThread());
@@ -160,37 +170,55 @@ void MediaCodecAudioDecoder::OnOutputFormatChanged() {
void MediaCodecAudioDecoder::Render(int buffer_index,
size_t offset,
size_t size,
- bool render_output,
+ RenderMode render_mode,
base::TimeDelta pts,
bool eos_encountered) {
DCHECK(decoder_thread_.task_runner()->BelongsToCurrentThread());
- DVLOG(2) << class_name() << "::" << __FUNCTION__ << " pts:" << pts;
+ DVLOG(2) << class_name() << "::" << __FUNCTION__ << " pts:" << pts << " "
+ << AsString(render_mode);
+
+ const bool do_play = (render_mode != kRenderSkip);
- render_output = render_output && (size != 0u);
+ if (do_play) {
+ AudioCodecBridge* audio_codec =
+ static_cast<AudioCodecBridge*>(media_codec_bridge_.get());
+
+ DCHECK(audio_codec);
+
+ const bool postpone = (render_mode == kRenderAfterPreroll);
- if (render_output) {
int64 head_position =
- (static_cast<AudioCodecBridge*>(media_codec_bridge_.get()))
- ->PlayOutputBuffer(buffer_index, size, offset);
+ audio_codec->PlayOutputBuffer(buffer_index, size, offset, postpone);
+
+ DVLOG(2) << class_name() << "::" << __FUNCTION__ << " pts:" << pts
+ << (postpone ? " POSTPONE" : "")
+ << " head_position:" << head_position;
size_t new_frames_count = size / bytes_per_frame_;
frame_count_ += new_frames_count;
audio_timestamp_helper_->AddFrames(new_frames_count);
- int64 frames_to_play = frame_count_ - head_position;
- DCHECK_GE(frames_to_play, 0);
- base::TimeDelta last_buffered = audio_timestamp_helper_->GetTimestamp();
- base::TimeDelta now_playing =
- last_buffered -
- audio_timestamp_helper_->GetFrameDuration(frames_to_play);
+ if (!postpone) {
+ int64 frames_to_play = frame_count_ - head_position;
- DVLOG(2) << class_name() << "::" << __FUNCTION__ << " pts:" << pts
- << " will play: [" << now_playing << "," << last_buffered << "]";
+ DCHECK_GE(frames_to_play, 0) << class_name() << "::" << __FUNCTION__
+ << " pts:" << pts
+ << " frame_count_:" << frame_count_
+ << " head_position:" << head_position;
+
+ base::TimeDelta last_buffered = audio_timestamp_helper_->GetTimestamp();
+ base::TimeDelta now_playing =
+ last_buffered -
+ audio_timestamp_helper_->GetFrameDuration(frames_to_play);
+
+ DVLOG(2) << class_name() << "::" << __FUNCTION__ << " pts:" << pts
+ << " will play: [" << now_playing << "," << last_buffered << "]";
- media_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(update_current_time_cb_, now_playing, last_buffered));
+ media_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(update_current_time_cb_, now_playing, last_buffered));
+ }
}
media_codec_bridge_->ReleaseOutputBuffer(buffer_index, false);
« no previous file with comments | « media/base/android/media_codec_audio_decoder.h ('k') | media/base/android/media_codec_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698