media/base/android/media_codec_bridge.h - Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_bridge.h

Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-browserseek

Patch Set: Rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_audio_decoder.cc ('K') | « media/base/android/media_codec_audio_decoder.cc ('k') | media/base/android/media_codec_bridge.cc » ('j') | media/base/android/media_codec_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_bridge.h

diff --git a/media/base/android/media_codec_bridge.h b/media/base/android/media_codec_bridge.h

index 8de5c4b24e0f33c6fb11fab661e2691a22175e09..79cb71c5d1da7b4bf505b3352212ef3d635a42af 100644

--- a/media/base/android/media_codec_bridge.h

+++ b/media/base/android/media_codec_bridge.h

@@ -236,7 +236,7 @@ class AudioCodecBridge : public MediaCodecBridge {

// Play the output buffer. This call must be called after

// DequeueOutputBuffer() and before ReleaseOutputBuffer. Returns the playback

// head position expressed in frames.

wolenetz 2015/08/20 20:37:36 nit: document postpone, index and size now that th

Tima Vaisburd 2015/08/20 22:36:36 Done.

- int64 PlayOutputBuffer(int index, size_t size);

+ int64 PlayOutputBuffer(int index, size_t size, bool postpone = false);

// Set the volume of the audio output.

void SetVolume(double volume);