Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1254223003: Revert of [Chromecast] Add explicit task_runner in CMA test (Closed)

Created:
5 years, 4 months ago by cleichner
Modified:
5 years, 4 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast] Add explicit task_runner in CMA test (patchset #4 id:60001 of https://codereview.chromium.org/1267563003/) Reason for revert: This was actually necessary because of a bug in which I incorrectly used weak_ptr in the internal change. That problem was caught in code review so this is no longer necessary. Original issue's description: > [Chromecast] Use BindToCurrentLoop in CMA test > > Without this the callback posts tasks on whatever thread it's callback > was originally called on, which can cause it to not respect the CMA > pipeline's threading assumptions. > > Committed: https://crrev.com/9104732746ce7dd18dee6308581e8e7327bb99f1 > Cr-Commit-Position: refs/heads/master@{#341043} TBR=erickung@google.com,kmackay@chromium.org,lcwu@google.com,halliwell@chromium.org,lcwu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/89ada2766db569000953e02db42d07eb59b05550 Cr-Commit-Position: refs/heads/master@{#341164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chromecast/media/cma/test/media_component_device_feeder_for_test.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
cleichner
Created Revert of [Chromecast] Add explicit task_runner in CMA test
5 years, 4 months ago (2015-07-30 18:43:49 UTC) #1
cleichner
5 years, 4 months ago (2015-07-30 18:44:00 UTC) #2
gunsch
rs lgtm
5 years, 4 months ago (2015-07-30 18:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254223003/1
5 years, 4 months ago (2015-07-30 18:44:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 18:45:44 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 18:46:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89ada2766db569000953e02db42d07eb59b05550
Cr-Commit-Position: refs/heads/master@{#341164}

Powered by Google App Engine
This is Rietveld 408576698