Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1254153002: MIPS64: Fix LoadGlobalViaContextStub (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix LoadGlobalViaContextStub Also make a minor improvement in the mips32 StoreGlobalViaContextStub and fix some bad comments in the macro-assembler. BUG= Committed: https://crrev.com/35d6012b9f9f4afb6454d4d510ab7b1471a6907b Cr-Commit-Position: refs/heads/master@{#29859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
akos.palfi.imgtec
Lgtm
5 years, 5 months ago (2015-07-25 18:54:27 UTC) #2
paul.l...
5 years, 5 months ago (2015-07-26 04:38:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254153002/1
5 years, 5 months ago (2015-07-26 04:39:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-26 05:01:48 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-26 05:02:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35d6012b9f9f4afb6454d4d510ab7b1471a6907b
Cr-Commit-Position: refs/heads/master@{#29859}

Powered by Google App Engine
This is Rietveld 408576698