Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1254143003: [stubs] Also handle properties of the JSBuiltinsObject in the fast case. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Also handle properties of the JSBuiltinsObject in the fast case. We can apply the shortcut used for data properties of the JSGlobalObject to builtin properties as well. This mostly affects the custom properties we use for the Math functions (i.e. rngstate for Math.random() and kMath for sin, cos and friends). Drive-by-fix: Also mark the internal builtin typed arrays properties (rngstate, kMath and rempio2result) as READ_ONLY, as they should not be touched after genesis. R=yangguo@chromium.org Committed: https://crrev.com/6cf94ebde1ad31dfce0af4dfa642468ec21b0174 Cr-Commit-Position: refs/heads/master@{#29887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-07-28 06:25:43 UTC) #1
Benedikt Meurer
Hey Yang, This is the fix I've told you about. It basically removes the restriction ...
5 years, 4 months ago (2015-07-28 06:26:46 UTC) #2
Yang
On 2015/07/28 06:26:46, Benedikt Meurer wrote: > Hey Yang, > > This is the fix ...
5 years, 4 months ago (2015-07-28 06:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254143003/1
5 years, 4 months ago (2015-07-28 06:28:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 06:48:13 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 06:48:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cf94ebde1ad31dfce0af4dfa642468ec21b0174
Cr-Commit-Position: refs/heads/master@{#29887}

Powered by Google App Engine
This is Rietveld 408576698