Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 1254133009: Explicit declare drm library directory (Closed)

Created:
5 years, 4 months ago by kalyank
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicit declare drm library directory I found this issue, while trying to use libdrm with some custom changes and not installed in the default system path. We are already checking drm system library and cflags using pkg, this patch extends it for the directory too. Committed: https://crrev.com/d1c9e302bc024e90299771d20b59bc6b5d18d999 Cr-Commit-Position: refs/heads/master@{#342229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/linux/system.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
kalyank
5 years, 4 months ago (2015-08-03 19:48:04 UTC) #2
alexst (slow to review)
Have spang look at it, my gyp skills are weak! :)
5 years, 4 months ago (2015-08-04 13:41:40 UTC) #4
spang
lgtm
5 years, 4 months ago (2015-08-04 15:16:39 UTC) #6
kalyank
On 2015/08/04 15:16:39, spang wrote: > lgtm @Jochen, Can you PTAL and do the Owner ...
5 years, 4 months ago (2015-08-05 16:09:17 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-06 07:44:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254133009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254133009/1
5 years, 4 months ago (2015-08-06 15:39:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89717)
5 years, 4 months ago (2015-08-06 17:28:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254133009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254133009/1
5 years, 4 months ago (2015-08-06 22:29:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 23:20:32 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:21:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1c9e302bc024e90299771d20b59bc6b5d18d999
Cr-Commit-Position: refs/heads/master@{#342229}

Powered by Google App Engine
This is Rietveld 408576698