Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 1254123003: Revert of mac: Switch the default build configuration to use the 10.10 SDK. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Nico, amineer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Switch the default build configuration to use the 10.10 SDK. (patchset #2 id:20001 of https://codereview.chromium.org/1246743003/) Reason for revert: Causes gclient runhooks to fail on bots that don't have the 10.10 SDK (even though they don't need to compile) Original issue's description: > mac: Switch the default build configuration to use the 10.10 SDK. > > This change is intended to be temporary. The goal is to release a Canary > compiled against the 10.10 SDK, and then to revert this CL. > > BUG=463170 > > Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451 > Cr-Commit-Position: refs/heads/master@{#340992} TBR=thakis@chromium.org,amineer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463170 Committed: https://crrev.com/53e1ddcd0f7bd0934157e149903feb1893e9aac7 Cr-Commit-Position: refs/heads/master@{#341003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of mac: Switch the default build configuration to use the 10.10 SDK.
5 years, 4 months ago (2015-07-29 22:39:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254123003/1
5 years, 4 months ago (2015-07-29 22:40:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 22:42:40 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 22:43:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53e1ddcd0f7bd0934157e149903feb1893e9aac7
Cr-Commit-Position: refs/heads/master@{#341003}

Powered by Google App Engine
This is Rietveld 408576698