Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1254123002: Revert of components: Make user_prefs a source_set. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of components: Make user_prefs a source_set. (patchset #1 id:1 of https://codereview.chromium.org/1258653002/) Reason for revert: Try to fix UserPrefs::Get() crashes. Original issue's description: > components: Make user_prefs a source_set. > > This is a tiny component, it does not need to be a shared libray in the > component build. > > BUG=None > R=brettw@chromium.org > > Committed: https://crrev.com/f8a72db8313967a512ea94c05b3951c255a4b796 > Cr-Commit-Position: refs/heads/master@{#340349} TBR=brettw@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/40f883687274257f05d2f933602318fcc6a5ed7f Cr-Commit-Position: refs/heads/master@{#340401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M components/user_prefs.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M components/user_prefs/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/user_prefs/user_prefs.h View 2 chunks +3 lines, -2 lines 0 comments Download
A components/user_prefs/user_prefs_export.h View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dcheng
Created Revert of components: Make user_prefs a source_set.
5 years, 5 months ago (2015-07-25 05:22:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254123002/1
5 years, 5 months ago (2015-07-25 05:22:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-25 05:22:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/40f883687274257f05d2f933602318fcc6a5ed7f Cr-Commit-Position: refs/heads/master@{#340401}
5 years, 5 months ago (2015-07-25 05:23:30 UTC) #4
tfarina
It does not look like related. Maybe it under covered something that was being hidden ...
5 years, 5 months ago (2015-07-25 17:01:44 UTC) #5
dcheng
The tree went green after the revert landed, so unfortunately, I'd say it's very much ...
5 years, 5 months ago (2015-07-25 17:06:19 UTC) #6
dcheng
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/17068 vs http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/17069
5 years, 5 months ago (2015-07-25 17:07:26 UTC) #7
tfarina
On 2015/07/25 17:06:19, dcheng wrote: > The tree went green after the revert landed, so ...
5 years, 5 months ago (2015-07-25 17:17:26 UTC) #8
brettw
5 years, 5 months ago (2015-07-25 20:59:17 UTC) #9
Message was sent while issue was closed.
Hey Thiago:

If you have two components that each depend on a static library or source set,
that static library or source set will be duplicated in each component. This is
fine for small things if there aren't too many things depending on it, but if
you do certain things like have a singleton, that singleton will now be
duplicated in each component. I suspect that's what's happening to you here.

I would not recommend messing with any component stuff, either adding or
removing them. I bet a lot can be removed, but it's almost impossible to tell
which ones. I did a few of these when doing the GN build and gave up.

Powered by Google App Engine
This is Rietveld 408576698