chrome/browser/task_management/providers/web_contents/panel_task.cc - Issue 1254103002: New Task Manager - Phase 1.3.5: Implement Extension Task Providing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/web_contents/panel_task.cc

Issue 1254103002: New Task Manager - Phase 1.3.5: Implement Extension Task Providing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Devlin's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/providers/web_contents/extension_task.cc ('k') | chrome/browser/task_management/providers/web_contents/renderer_task.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/web_contents/panel_task.cc

diff --git a/chrome/browser/task_management/providers/web_contents/panel_task.cc b/chrome/browser/task_management/providers/web_contents/panel_task.cc

index e69b7f1be8013bc3f50655c12b775b52b8135ec2..5198adcbd8abad4001e81a2d8b513132ae026102 100644

--- a/chrome/browser/task_management/providers/web_contents/panel_task.cc

+++ b/chrome/browser/task_management/providers/web_contents/panel_task.cc

@@ -53,13 +53,14 @@ base::string16 PanelTask::GetCurrentPanelTitle(Panel* panel) const {

const extensions::Extension* extension =

registry->enabled_extensions().GetByID(panel->extension_id());

- const bool is_app = extension ? extension->is_app() : false;

+ const bool is_app = extension && extension->is_app();

const bool is_incognito = panel->profile()->IsOffTheRecord();

return PrefixRendererTitle(title,

is_app,

true, // is_extension.

- is_incognito);

+ is_incognito,

+ false); // is_background.

}

} // namespace task_management